New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix user talk parameters for db-multiple in twinklespeedy #218

Closed
atlight opened this Issue May 1, 2014 · 0 comments

Comments

Projects
None yet
1 participant
@atlight
Collaborator

atlight commented May 1, 2014

https://en.wikipedia.org/wiki/Wikipedia_talk:TW#Bug_report:_wikilink_in_CSD_report_broken

twinklespeedy.js line 1326 has params.utparams = [];, which is nonsense (I'm allowed to say that because I wrote that bit of code myself).

The whole if block should be replaced by something similar to

                code = "{{db-multiple";
                params.utparams = [];
                $.each(params.normalizeds, function(index, norm) {
                    // ...
                    params.utparams = params.utparams.concat(Twinkle.speedy.getUserTalkParameters(norm, parameters));
                });
                code += "}}";

I'll do this soon when I'm on a computer with git.

(I'm not really sure why this code is using for-in loops, but I guess they don't hurt.)

@atlight atlight self-assigned this May 1, 2014

@atlight atlight closed this in da682ef May 2, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment