New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TW incorrectly deletes a page as a redirect to a CSD target when it is not. #296

Closed
HighInBC opened this Issue Oct 19, 2015 · 5 comments

Comments

Projects
None yet
3 participants
@HighInBC

HighInBC commented Oct 19, 2015

I used twinkle to delete https://en.wikipedia.org/w/index.php?title=Ruben_Correa per G10. It deleted https://en.wikipedia.org/wiki/User_talk:Rjwilmsi on that basis that it was a redirect to that article, however it was not. This was the state of the page when it was deleted: [https://en.wikipedia.org/w/index.php?title=User_talk:RjwilmsiBot&oldid=686505612].

The bug appears to be in not realizing the redirect is separate from the message below the redirect.

@azatoth

This comment has been minimized.

Show comment
Hide comment
@azatoth

azatoth Oct 19, 2015

Owner

The modules uses the query/backlinks API to get the redirects; it doesn't parse the page at all; so if something went wrong, it's due to MW borking out. see https://github.com/azatoth/twinkle/blob/master/modules/twinklespeedy.js#L1136-L1187

Owner

azatoth commented Oct 19, 2015

The modules uses the query/backlinks API to get the redirects; it doesn't parse the page at all; so if something went wrong, it's due to MW borking out. see https://github.com/azatoth/twinkle/blob/master/modules/twinklespeedy.js#L1136-L1187

@azatoth

This comment has been minimized.

Show comment
Hide comment
@azatoth
Owner

azatoth commented Oct 19, 2015

@atlight

This comment has been minimized.

Show comment
Hide comment
@atlight

atlight Oct 19, 2015

Collaborator

Not a MW bug; twinkle should use prop=redirects instead of list=backlinks.

Collaborator

atlight commented Oct 19, 2015

Not a MW bug; twinkle should use prop=redirects instead of list=backlinks.

@atlight atlight reopened this Oct 19, 2015

@azatoth

This comment has been minimized.

Show comment
Hide comment
@azatoth

azatoth Oct 19, 2015

Owner

whoops

Owner

azatoth commented Oct 19, 2015

whoops

@atlight

This comment has been minimized.

Show comment
Hide comment
@atlight

atlight Oct 23, 2015

Collaborator

Fixed by ae6802e (speedy, thanks to @MusikAnimal) and e3ed44f (batchdelete and deprod).

Collaborator

atlight commented Oct 23, 2015

Fixed by ae6802e (speedy, thanks to @MusikAnimal) and e3ed44f (batchdelete and deprod).

@atlight atlight closed this Oct 23, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment