New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slightly more accurate T3 desc label #211

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@Technical-13
Contributor

Technical-13 commented Mar 14, 2014

Per Andy Mabbett https://en.wikipedia.org/wiki/User:Pigsonthewing -- The wording this script offers for WP:CSD#T3 is quite broad:

Templates that are not used in any useful fashion

but the wording of the actual criterion is much stricter:

Templates that are substantial duplications of another template, or hardcoded instances of another template where the same functionality could be provided by that other template

Can the Twinkle version be tightened up, to more closely reflect the latter, please? Perhaps:

Templates that are substantial or hardcoded duplications of another template

Is this something editors such as I can do? Andy Mabbett (Pigsonthewing); Talk to Andy; Andy's edits 6:19 pm, Today (UTC−4)

Sure... Submit a pull request on GitHub ( https://github.com/azatoth/twinkle — more specifically near: https://github.com/azatoth/twinkle/blob/master/modules/twinklespeedy.js#L676 ). — {{U|Technical 13}} (t • e • c) 6:31 pm, Today (UTC−4)

    I'm neither a coder nor a github user. Andy Mabbett (Pigsonthewing); Talk to Andy; Andy's edits 6:37 pm, Today (UTC−4)
Slightly more accurate T3 desc label
Per Andy Mabbett https://en.wikipedia.org/wiki/User:Pigsonthewing -- The wording this script offers for WP:CSD#T3 is quite broad:

    Templates that are not used in any useful fashion

but the wording of the actual criterion is much stricter:

    Templates that are substantial duplications of another template, or hardcoded instances of another template where the same functionality could be provided by that other template

Can the Twinkle version be tightened up, to more closely reflect the latter, please? Perhaps:

    Templates that are substantial or hardcoded duplications of another template

Is this something editors such as I can do? Andy Mabbett (Pigsonthewing); Talk to Andy; Andy's edits 6:19 pm, Today (UTC−4)

    Sure... Submit a pull request on GitHub ( https://github.com/azatoth/twinkle — more specifically near: https://github.com/azatoth/twinkle/blob/master/modules/twinklespeedy.js#L676 ). — {{U|Technical 13}} (t • e • c) 6:31 pm, Today (UTC−4)

        I'm neither a coder nor a github user. Andy Mabbett (Pigsonthewing); Talk to Andy; Andy's edits 6:37 pm, Today (UTC−4)
@atlight

This comment has been minimized.

Show comment
Hide comment
@atlight

atlight Mar 16, 2014

Collaborator

See discussion at WT:TW. Also I would prefer to see a more succinct commit message. It could simply link to this issue.

Collaborator

atlight commented Mar 16, 2014

See discussion at WT:TW. Also I would prefer to see a more succinct commit message. It could simply link to this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment