New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

twinkle.js: Update Twinkle.addPortlet() to work after recent MW changes #225

Merged
merged 1 commit into from Jun 13, 2014

Conversation

Projects
None yet
3 participants
@MatmaRex
Contributor

MatmaRex commented Jun 13, 2014

Vector's dropdown menu styles were recently cleaned up and a label is
now shown by default (https://gerrit.wikimedia.org/r/#/c/112236/),
hacks that Twinkle has been doing are no longer needed and in fact
break the display (https://en.wikipedia.org/wiki/WP:VPT#Misinterface_layout).

The README is pretty confusing, I hope this is the right file to edit
(I didn't find this code in any other one).

twinkle.js: Update Twinkle.addPortlet() to work after recent MW changes
Vector's dropdown menu styles were recently cleaned up and a label is
now shown by default (https://gerrit.wikimedia.org/r/#/c/112236/),
hacks that Twinkle has been doing are no longer needed and in fact
break the display (https://en.wikipedia.org/wiki/WP:VPT#Misinterface_layout).

The README is pretty confusing, I hope this is the right file to edit
(I didn't find this code in any other one).

azatoth added a commit that referenced this pull request Jun 13, 2014

Merge pull request #225 from MatmaRex/patch-1
twinkle.js: Update Twinkle.addPortlet() to work after recent MW changes

@azatoth azatoth merged commit 10b8ecf into azatoth:master Jun 13, 2014

@atlight

This comment has been minimized.

Collaborator

atlight commented Jun 13, 2014

Thanks for this, Bartosz. Yeah the readme needs some work. It's mainly intended for people involved in updating the gadget on-wiki. I think the file structure of this repo is fairly obvious, but maybe it's just me :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment