morebits: Ignore file/category embeds when removing links #239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
morebits.js
Outdated
| @@ -2999,10 +2999,11 @@ Morebits.wikitext.page = function mediawikiPage( text ) { | |||
| Morebits.wikitext.page.prototype = { | |||
| text: '', | |||
| removeLink: function( link_target ) { | |||
| var not_link_re_string = "(?!(?:[Ff]ile|[Ii]mage|[Cc]ategory):)"; | |||
There was a problem hiding this comment.
I didn't test it (no time right now...), but it seems that JavaScript doesn't support lookbehinds. In any case ?! is a lookahead, not a lookbehind. Could you test this anyway in a browser and see what happens?
There was a problem hiding this comment.
It's a lookahead, which is what I wanted. I'll try to test this in a bit.
There was a problem hiding this comment.
Any chance this can be constructed from wgNamespaceIds? For the sake of l10n...
|
You could ask Magioalditis or even Reaper Eternal (since RE made many edit filters with regexes). |
File: and Category: links (without a leading colon) should not be removed. Fixes #231.
kevinji
force-pushed
the
morebits-wikitext
branch
from
586037e
to
f4a82fa
Compare
kevinji
changed the title
|
I've finally come back to this with a simpler solution (no lookaheads!). |
Siddhartha-Ghai
pushed a commit
to Siddhartha-Ghai/twinkle
that referenced
this pull request
Jan 3, 2019
…gadgets#239) File: and Category: links (without a leading colon) should not be removed. Fixes wikimedia-gadgets#231. (cherry picked from commit 83fff83)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #231. @atlight Could I get a second pair of eyes on that regex? I'm pretty sure it's correct but I might have made a simple mistake.