New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent jumping to next section when target section is empty #291

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@jcgoble3

jcgoble3 commented Sep 15, 2015

Multiple reports have been made to WT:TW regarding protection requests being posted in the wrong section. The common thread between all reported cases is that the target section was empty at the time.

According to testing I did on a copy of the RFPP page in Notepad++, the problem was that the regex was consuming both the target section and the following section when the target section was empty. I'm honestly not sure how this fixes the problem, but Notepad++ testing says that it does. I'll just call it black magic and not argue with it. :P

@atlight

This comment has been minimized.

Collaborator

atlight commented Sep 15, 2015

Yeah, this is a known issue. It's quite a fickle regex, I'll have to do some more testing before I merge this.

@jcgoble3

This comment has been minimized.

jcgoble3 commented Sep 15, 2015

Given the complexity of the regex, have you considered a more verbose definition? JS doesn't technically support verbose regexes, but it can be faked with string concatenation and normal comments. That might be worth considering here, so you can more precisely document exactly what each token is intended to match.

@jcgoble3

This comment has been minimized.

jcgoble3 commented Nov 11, 2015

Any update on this?

@jcgoble3

This comment has been minimized.

jcgoble3 commented Jan 19, 2016

Obsoleted by 6b02198. Closing request and will be deleting my fork.

@jcgoble3 jcgoble3 closed this Jan 19, 2016

@jcgoble3 jcgoble3 deleted the jcgoble3:rpp-empty-section-fix branch Jan 19, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment