New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust {{uw-3rr}} description #342

Merged
merged 1 commit into from Jun 5, 2016

Conversation

Projects
None yet
2 participants
@stickee-wp
Contributor

stickee-wp commented Jun 1, 2016

A discussion on WT:TWINKLE has resulted in a consensus that the edit summary left by Twinkle shouldn't imply the user has broken the 3RR. The warning itself {{uw-3rr}} doesn't say the user has broken 3RR, so neither should the edit summary.

@stickee-wp stickee-wp changed the title from Shorten {{uw-3rr}} description to Adjust {{uw-3rr}} description Jun 1, 2016

Show outdated Hide outdated modules/twinklewarn.js Outdated
@stickee-wp

This comment has been minimized.

Show comment
Hide comment
@stickee-wp

stickee-wp Jun 2, 2016

Contributor

Okay @atlight, how's that? I used similar warning to that at WP:WARN. I'm open to any other wording, it's really just the edit summary that matters.

Contributor

stickee-wp commented Jun 2, 2016

Okay @atlight, how's that? I used similar warning to that at WP:WARN. I'm open to any other wording, it's really just the edit summary that matters.

@atlight

This comment has been minimized.

Show comment
Hide comment
@atlight

atlight Jun 2, 2016

Collaborator

Excellent! If you can squash the two commits into one, I'll merge.

Collaborator

atlight commented Jun 2, 2016

Excellent! If you can squash the two commits into one, I'll merge.

Shorten {{uw-3rr}} description
Adjust 3RR description and edit summary so it doesn't imply user has violated the 3RR.
@stickee-wp

This comment has been minimized.

Show comment
Hide comment
@stickee-wp

stickee-wp Jun 2, 2016

Contributor

Squashed. Ready for merge.

Contributor

stickee-wp commented Jun 2, 2016

Squashed. Ready for merge.

@atlight atlight merged commit 42b638c into azatoth:master Jun 5, 2016

@atlight

This comment has been minimized.

Show comment
Hide comment
@atlight

atlight Jun 5, 2016

Collaborator

Sorry for the wait.

Collaborator

atlight commented Jun 5, 2016

Sorry for the wait.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment