Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed deprecated tests-as-filters #14

Merged
merged 2 commits into from Apr 3, 2019

Conversation

Projects
None yet
2 participants
@9999years
Copy link
Contributor

9999years commented Mar 28, 2019

There were a few instances of result | failed (or similar) which I've
removed. I also factored out an extremely long line in the "Download
get-pip.py" line to a variable and added a 'pip_executable' variable
(even after pip was installed, a misconfigured PATH would make 'pip
--version' still fail).

Removed deprecated tests-as-filters
There were a few instances of `result | failed` (or similar) which I've
removed. I also factored out an extremely long line in the "Download
get-pip.py" line to a variable and added a 'pip_executable' variable
(even after pip was installed, a misconfigured PATH would make 'pip
--version' still fail).

@9999years 9999years force-pushed the 9999years:develop branch from 7a2d5bc to ee489ac Mar 28, 2019

@hectcastro

This comment has been minimized.

Copy link
Member

hectcastro commented Mar 30, 2019

Hey @9999years, thank for taking the time to create a PR. Can you please update min_ansible_version in meta/main.yml with the minimum Ansible version that supports your changes?

Bumped min_ansible_version from 1.8 to 2.5
tests-as-filters were deprecated with Ansible 2.5 and will be removed in
Ansible 2.9.
@9999years

This comment has been minimized.

Copy link
Contributor Author

9999years commented Apr 2, 2019

Done, bumped version to 2.5.

@hectcastro

This comment has been minimized.

Copy link
Member

hectcastro commented Apr 3, 2019

Thank you!

@hectcastro hectcastro merged commit dda6e7a into azavea:develop Apr 3, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.