Create stock overpass query using drawn shape #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kellyi
force-pushed
the
ki/create-stock-overpass-query
branch
3 times, most recently
from
8183a8f
to
3bcfb20
Compare
kellyi
changed the title
|
|
added 5 commits
July 17, 2018 16:57
- add some utility functions which can send a geojson polygon to the overpass api, along with a stock request for building data - update map component to display building data by point
kellyi
force-pushed
the
ki/create-stock-overpass-query
branch
from
3bcfb20
to
ea425ab
Compare
rajadain
approved these changes
Jul 17, 2018
There was a problem hiding this comment.
+1 tested and works in both IE11 and Chrome. Not in this PR, but we'll need to refine this workflow somewhat. I think it's more natural for us to fetch the values and show them on screen before the user clicks "extract" to download the shapefile, but given the delay of the fetch it makes sense to have a button that starts that too.
Sounds good to me. I'll tweak it a little while working on #8 |
|
Thanks for reviewing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR creates a stock overpass query using the drawn shape sent by the user.
The workflow for this is currently not the most apparent, but we can fix that as we go.
Connects #6
Demo
Notes
We're going to have to make this Overpass API request way more configurable but it's better to push off handling that until we have the configuration for the actual set of features.
Testing Instructions
updateandserver