Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit Tests: `utils` and `task` #497

Merged
merged 6 commits into from Oct 22, 2018

Conversation

Projects
None yet
1 participant
@jamesmcclain
Copy link
Member

jamesmcclain commented Oct 15, 2018

Overview

Brief description of what this PR does, and why it is needed.

Checklist

  • Ran scripts/format_code and commited any changes
  • Documentation updated if needed
  • PR has a name that won't get you publicly shamed for vagueness

Notes

Optional. Ancillary topics, caveats, alternative strategies that didn't work out, anything else.

Testing Instructions

  • How to test this PR
  • Prefer bulleted description
  • Start after checking out this branch
  • Include any setup required, such as rebuilding the Docker image.
  • Include test case, and expected output if not captured by automated tests.

Closes #496
Closes #498
Depends on #490

@jamesmcclain jamesmcclain added the review label Oct 15, 2018

@jamesmcclain jamesmcclain changed the title Backfill `utils` Unit Tests Backfill `util(s|)` Unit Tests Oct 15, 2018

@jamesmcclain jamesmcclain force-pushed the jamesmcclain:backfill-2 branch from 484181a to a5e4b05 Oct 15, 2018

@jamesmcclain jamesmcclain changed the title Backfill `util(s|)` Unit Tests Unit Tests: `utils` and `task` Oct 15, 2018

@codecov

This comment has been minimized.

Copy link

codecov bot commented Oct 15, 2018

Codecov Report

Merging #497 into develop will increase coverage by 0.82%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #497      +/-   ##
===========================================
+ Coverage    66.02%   66.84%   +0.82%     
===========================================
  Files          174      155      -19     
  Lines         7331     6895     -436     
===========================================
- Hits          4840     4609     -231     
+ Misses        2491     2286     -205
Impacted Files Coverage Δ
rastervision/utils/files.py 89.47% <100%> (+18.04%) ⬆️
rastervision/filesystem/local_filesystem.py 97.75% <0%> (-1.13%) ⬇️
rastervision/runner/aws_batch_experiment_runner.py 16.66% <0%> (ø) ⬆️
rastervision/data/raster_source/__init__.py
rastervision/data/label_store/__init__.py
rastervision/utils/filter_geojson.py
rastervision/experiment/__init__.py
rastervision/task/object_detection.py
rastervision/backend/__init__.py
rastervision/__init__.py
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3ebd69e...2384dc6. Read the comment docs.

@jamesmcclain jamesmcclain deleted the jamesmcclain:backfill-2 branch Oct 15, 2018

@jamesmcclain jamesmcclain removed the review label Oct 15, 2018

@jamesmcclain jamesmcclain restored the jamesmcclain:backfill-2 branch Oct 15, 2018

@jamesmcclain jamesmcclain reopened this Oct 15, 2018

@jamesmcclain jamesmcclain added the review label Oct 15, 2018

jamesmcclain added some commits Oct 15, 2018

Suffix of `None` Not Allowed
`get_matching_s3_keys` fails when `suffix` is `None`.
Domain of Integration Tests
Chip classification, object detection, and semantic segmentation are
better tested by integration tests.

@jamesmcclain jamesmcclain force-pushed the jamesmcclain:backfill-2 branch from b3bcbda to 2384dc6 Oct 17, 2018

@jamesmcclain jamesmcclain merged commit fcce28c into azavea:develop Oct 22, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@jamesmcclain jamesmcclain deleted the jamesmcclain:backfill-2 branch Oct 22, 2018

@jamesmcclain jamesmcclain removed the review label Oct 22, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.