Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused args for Batch runner #503

Merged
merged 1 commit into from Oct 16, 2018
Merged

Remove unused args for Batch runner #503

merged 1 commit into from Oct 16, 2018

Conversation

@lewfish
Copy link
Contributor

@lewfish lewfish commented Oct 16, 2018

This PR removes some unused args in the Batch runner code. The reference to self.branch caused an error. I tested by running locally and it fixed the problem.

@lewfish lewfish added the review label Oct 16, 2018
@codecov
Copy link

@codecov codecov bot commented Oct 16, 2018

Codecov Report

Merging #503 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #503   +/-   ##
========================================
  Coverage    66.02%   66.02%           
========================================
  Files          174      174           
  Lines         7331     7331           
========================================
  Hits          4840     4840           
  Misses        2491     2491
Impacted Files Coverage Δ
rastervision/runner/aws_batch_experiment_runner.py 16.66% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9465345...a623a3d. Read the comment docs.

@lewfish lewfish requested a review from lossyrob Oct 16, 2018
The reference to self.branch caused an error
@lewfish lewfish force-pushed the lf/remove-branch branch from 8736bf7 to a623a3d Oct 16, 2018
@lossyrob lossyrob merged commit 3ebd69e into develop Oct 16, 2018
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@lossyrob lossyrob deleted the lf/remove-branch branch Oct 16, 2018
@lossyrob lossyrob removed the review label Oct 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants