Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fixes for Vegas example #507

Merged
merged 2 commits into from Oct 19, 2018

Conversation

Projects
None yet
1 participant
@lewfish
Copy link
Contributor

lewfish commented Oct 17, 2018

Overview

This PR fixes two bugs that came up in the course of running azavea/raster-vision-examples#10. See commits for details.

Checklist

  • Ran scripts/format_code and commited any changes
  • Documentation updated if needed
  • PR has a name that won't get you publicly shamed for vagueness

Testing Instructions

  • Added unit test and chip classification on buildings works.

lewfish added some commits Oct 17, 2018

Skip over lines when doing chip classification
Previously we were raising an error which made it impossible to use with
space net buildings, which for some reason has some lines in it.
Use background_class_id for scenes with no polygons
Also add new unit test for this condition

@lewfish lewfish added the review label Oct 17, 2018

@lewfish lewfish changed the title Bug fixes Bug fixes for Vegas example Oct 17, 2018

@codecov

This comment has been minimized.

Copy link

codecov bot commented Oct 17, 2018

Codecov Report

Merging #507 into develop will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #507      +/-   ##
===========================================
+ Coverage    66.02%   66.03%   +0.01%     
===========================================
  Files          174      174              
  Lines         7331     7329       -2     
===========================================
  Hits          4840     4840              
+ Misses        2491     2489       -2
Impacted Files Coverage Δ
...label_source/chip_classification_geojson_source.py 96.66% <100%> (+1.5%) ⬆️
rastervision/data/raster_source/geojson_source.py 94.59% <100%> (+2.7%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3ebd69e...8bd2c41. Read the comment docs.

@lewfish lewfish merged commit a49383c into develop Oct 19, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@lewfish lewfish deleted the lf/fixes branch Oct 19, 2018

@lewfish lewfish removed the review label Oct 19, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.