Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Support for Shifting Rasters #573

Merged
merged 7 commits into from Nov 28, 2018

Conversation

Projects
None yet
2 participants
@jamesmcclain
Copy link
Member

jamesmcclain commented Nov 21, 2018

Overview

Modifies the window used in the get_chip method to "shift" input raster(s) by some number of meters in the x and/or y direction(s). The rasters are not changed on disk. Pursuant to #560 .

[xy]_shift_meters parameters have been added to GeoTiffFiles.

A positive x shift moves the "camera" to to the right. A positive y shift moves the "camera" down.

Checklist

  • Ran scripts/format_code and commited any changes
  • Documentation updated if needed
  • PR has a name that won't get you publicly shamed for vagueness

Notes

Optional. Ancillary topics, caveats, alternative strategies that didn't work out, anything else.

Testing Instructions

  • How to test this PR
  • Prefer bulleted description
  • Start after checking out this branch
  • Include any setup required, such as rebuilding the Docker image.
  • Include test case, and expected output if not captured by automated tests.

Closes ##560

@jamesmcclain jamesmcclain added the review label Nov 21, 2018

@jamesmcclain jamesmcclain force-pushed the jamesmcclain:shift branch from c3fe234 to e0b1af2 Nov 25, 2018

@lewfish
Copy link
Contributor

lewfish left a comment

Looks good aside from potential readability changes.

@jamesmcclain

This comment has been minimized.

Copy link
Member Author

jamesmcclain commented Nov 26, 2018

I will make the requested changes this evening or tomorrow morning.

@jamesmcclain jamesmcclain changed the title [WiP] Add Support for Shifting Rasters Add Support for Shifting Rasters Nov 28, 2018

jamesmcclain added some commits Nov 20, 2018

@jamesmcclain jamesmcclain force-pushed the jamesmcclain:shift branch from e0b1af2 to fa62418 Nov 28, 2018

@jamesmcclain jamesmcclain force-pushed the jamesmcclain:shift branch from fa62418 to 4dd5b21 Nov 28, 2018

@jamesmcclain jamesmcclain merged commit 374b7ce into azavea:develop Nov 28, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@jamesmcclain jamesmcclain removed the review label Nov 28, 2018

@jamesmcclain jamesmcclain deleted the jamesmcclain:shift branch Nov 28, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.