Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Extraction #575

Merged
merged 25 commits into from Jan 3, 2019

Conversation

Projects
None yet
2 participants
@jamesmcclain
Copy link
Member

jamesmcclain commented Nov 26, 2018

Overview

Adds ability to produce a GeoJSON file containing semantic segmentation predictions.

The ProtoBuf schema has been updated to include a list of vector outputs.

The segmentation integration test gives the following results:

mask
screenshot from 2018-12-05 14-38-44

Evaluation of vector outputs has been left for future work (see #611 ).

polygon output mode left for future work (see #612 ).

Checklist

  • Ran scripts/format_code and commited any changes
  • Documentation updated if needed
  • PR has a name that won't get you publicly shamed for vagueness

Notes

Optional. Ancillary topics, caveats, alternative strategies that didn't work out, anything else.

Testing Instructions

  • How to test this PR
  • Prefer bulleted description
  • Start after checking out this branch
  • Include any setup required, such as rebuilding the Docker image.
  • Include test case, and expected output if not captured by automated tests.

Closes #544
Closes #611
Closes #612
Closes #564

@jamesmcclain jamesmcclain added the review label Nov 26, 2018

@jamesmcclain jamesmcclain changed the title [WiP] Feature extraction [WiP] Feature Extraction Nov 27, 2018

@jamesmcclain jamesmcclain force-pushed the jamesmcclain:feature-extraction branch 4 times, most recently from 67aa06a to e704aa2 Nov 27, 2018

@jamesmcclain jamesmcclain changed the title [WiP] Feature Extraction Feature Extraction Nov 28, 2018

@jamesmcclain jamesmcclain force-pushed the jamesmcclain:feature-extraction branch from ac65ed8 to a3afcb8 Nov 29, 2018

@lewfish

This comment has been minimized.

Copy link
Contributor

lewfish commented Nov 29, 2018

I haven't looked at this in any detail yet, but one request is to add polygon mode which extracts polygons without doing the extra right-angle stuff for buildings.

Show resolved Hide resolved requirements-dev.txt
Show resolved Hide resolved Dockerfile Outdated
Show resolved Hide resolved rastervision/data/scene_config.py Outdated
Show resolved Hide resolved rastervision/data/label_store/semantic_segmentation_raster_store.py Outdated
Show resolved Hide resolved rastervision/data/label_store/semantic_segmentation_raster_store.py Outdated
Show resolved Hide resolved integration_tests/semantic_segmentation_tests/experiment.py Outdated
Show resolved Hide resolved rastervision/data/label_store/semantic_segmentation_raster_store.py Outdated
Show resolved Hide resolved rastervision/data/scene_config.py Outdated
Show resolved Hide resolved rastervision/data/label_store/semantic_segmentation_raster_store_config.py Outdated

@jamesmcclain jamesmcclain deleted the jamesmcclain:feature-extraction branch Dec 3, 2018

@jamesmcclain jamesmcclain removed the review label Dec 3, 2018

@jamesmcclain jamesmcclain restored the jamesmcclain:feature-extraction branch Dec 3, 2018

@jamesmcclain jamesmcclain reopened this Dec 3, 2018

@jamesmcclain jamesmcclain added the review label Dec 3, 2018

@jamesmcclain jamesmcclain force-pushed the jamesmcclain:feature-extraction branch 2 times, most recently from 70afc8e to a012077 Dec 3, 2018

@lewfish

This comment has been minimized.

Copy link
Contributor

lewfish commented Dec 6, 2018

Evaluation of vector outputs has been left for future work.

polygon output mode left for future work.

Whenever you decide that something is outside the scope of a PR and is left for future work, it is a good idea to make an issue for those tasks and link to them in the PR.

Also, reminder to remove unused boilerplate text from the PR description.

@jamesmcclain jamesmcclain force-pushed the jamesmcclain:feature-extraction branch from cedcff0 to 5131900 Dec 12, 2018

@lewfish
Copy link
Contributor

lewfish left a comment

Will test after change.

@jamesmcclain jamesmcclain force-pushed the jamesmcclain:feature-extraction branch 2 times, most recently from 2b9e790 to 86a0d2e Dec 12, 2018

@lewfish

This comment has been minimized.

Copy link
Contributor

lewfish commented Dec 13, 2018

I tested this using a modification of the Vegas example in
azavea/raster-vision-examples@65417f6 azavea/raster-vision-examples@337b244

The command run was

export ROOT_URI=/opt/data/lf-dev/rv-output/vegas-spacenet
rastervision run local -e spacenet.vegas \
    -a test True \
    -a use_remote_data False \
    -a root_uri ${ROOT_URI} \
    -a target buildings \
    -a task_type semantic_segmentation

If you don't have the Vegas data on your local filesystem you can switch use_remote_data to True.

I noticed that there were some junk predictions of buildings and expected there to be some polygons output for them, but there weren't any.

@lewfish

This comment has been minimized.

Copy link
Contributor

lewfish commented Dec 13, 2018

Note that I updated the branch/commit that the Vegas test is in above.

@jamesmcclain jamesmcclain force-pushed the jamesmcclain:feature-extraction branch from 86a0d2e to b68b990 Dec 18, 2018

jamesmcclain added some commits Nov 26, 2018

@jamesmcclain jamesmcclain force-pushed the jamesmcclain:feature-extraction branch from ca93b5d to 81e2cb8 Jan 3, 2019

@jamesmcclain jamesmcclain merged commit 7eafab6 into azavea:develop Jan 3, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@jamesmcclain jamesmcclain deleted the jamesmcclain:feature-extraction branch Jan 3, 2019

@jamesmcclain jamesmcclain removed the review label Jan 3, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.