Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes to experiment config copy and rasterio source #576

Merged
merged 5 commits into from Nov 27, 2018

Conversation

Projects
None yet
2 participants
@lossyrob
Copy link
Member

commented Nov 27, 2018

This PR fixes two small issues:

  • The keys (e.g. analyze_key) were not being copied with the experiment config _copy method.
  • The test chip in the __init__ method for the RasterioRasterSource was not transforming the chip correctly for raster sources that had a channel order set.

@lossyrob lossyrob added the review label Nov 27, 2018

lossyrob added some commits Nov 27, 2018

@lewfish
Copy link
Contributor

left a comment

Waiting for build to finish before merging.

@lossyrob lossyrob added this to the 0.8.2 milestone Nov 27, 2018

@codecov

This comment has been minimized.

Copy link

commented Nov 27, 2018

Codecov Report

Merging #576 into develop will decrease coverage by 2.34%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #576      +/-   ##
===========================================
- Coverage    71.59%   69.24%   -2.35%     
===========================================
  Files          169      169              
  Lines         7575     7595      +20     
===========================================
- Hits          5423     5259     -164     
- Misses        2152     2336     +184
Impacted Files Coverage Δ
rastervision/data/raster_source/rasterio_source.py 93.1% <100%> (+0.12%) ⬆️
rastervision/experiment/experiment_config.py 97.88% <100%> (+6.57%) ⬆️
rastervision/command/chip_command.py 35.71% <0%> (-64.29%) ⬇️
rastervision/command/analyze_command.py 38.46% <0%> (-61.54%) ⬇️
rastervision/command/eval_command.py 38.46% <0%> (-61.54%) ⬇️
rastervision/command/predict_command.py 41.66% <0%> (-58.34%) ⬇️
rastervision/task/task.py 26.66% <0%> (-57.34%) ⬇️
rastervision/command/train_command.py 45.45% <0%> (-54.55%) ⬇️
rastervision/runner/aws_batch_experiment_runner.py 15.66% <0%> (-43.38%) ⬇️
rastervision/runner/local_experiment_runner.py 58.33% <0%> (-41.67%) ⬇️
... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 014da06...b4cdcbb. Read the comment docs.

@lewfish lewfish merged commit 2603f12 into develop Nov 27, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@lewfish lewfish deleted the rde/fix/small-fix branch Nov 27, 2018

@lewfish lewfish removed the review label Nov 27, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.