Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle multiple AOI URIs #617

Merged
merged 1 commit into from Dec 13, 2018

Conversation

Projects
None yet
2 participants
@lewfish
Copy link
Contributor

lewfish commented Dec 12, 2018

Overview

This PR adds a with_aoi_uris method to SceneConfigBuilder to handle multiple files containing AOIs. This makes it easier to select arbitrary subsets of AOIs to associate with a scene when experimenting. The original with_aoi_uri method, and aoi_uri Scene protobuf fields are still intact and functional for backward compatibility,

Closes #615

@lewfish lewfish added the review label Dec 12, 2018

@codecov

This comment has been minimized.

Copy link

codecov bot commented Dec 12, 2018

Codecov Report

Merging #617 into develop will increase coverage by 0.03%.
The diff coverage is 81.25%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #617      +/-   ##
===========================================
+ Coverage    72.08%   72.11%   +0.03%     
===========================================
  Files          171      171              
  Lines         7798     7807       +9     
===========================================
+ Hits          5621     5630       +9     
  Misses        2177     2177
Impacted Files Coverage Δ
rastervision/data/scene_config.py 77.41% <81.25%> (+1.39%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fb58fdc...dbc19b1. Read the comment docs.

@codecov

This comment has been minimized.

Copy link

codecov bot commented Dec 12, 2018

Codecov Report

Merging #617 into develop will increase coverage by 0.03%.
The diff coverage is 81.25%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #617      +/-   ##
===========================================
+ Coverage    72.08%   72.11%   +0.03%     
===========================================
  Files          171      171              
  Lines         7798     7807       +9     
===========================================
+ Hits          5621     5630       +9     
  Misses        2177     2177
Impacted Files Coverage Δ
rastervision/data/scene_config.py 77.41% <81.25%> (+1.39%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fb58fdc...42c8f62. Read the comment docs.

@lewfish lewfish requested a review from jamesmcclain Dec 12, 2018

@@ -22,5 +22,9 @@ message SceneConfig {
optional LabelStoreConfig prediction_label_store = 4;

// Optional AOI that describes where the scene is fully labeled.

// XXX here for backward compatibility
optional string aoi_uri = 5;

This comment has been minimized.

Copy link
@jamesmcclain

This comment has been minimized.

Copy link
@lewfish

lewfish Dec 13, 2018

Author Contributor

True, I took it out.

@lewfish lewfish force-pushed the lf/multi-aois branch from 42c8f62 to dbc19b1 Dec 13, 2018

@lewfish lewfish merged commit 69d3bbf into develop Dec 13, 2018

0 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/travis-ci/push The Travis CI build is in progress
Details

@lewfish lewfish deleted the lf/multi-aois branch Dec 13, 2018

@lewfish lewfish removed the review label Dec 13, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.