Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle width > height in semseg eval #627

Merged
merged 1 commit into from Dec 17, 2018

Conversation

Projects
None yet
2 participants
@lewfish
Copy link
Contributor

lewfish commented Dec 14, 2018

Overview

This fixes a bug in the semantic segmentation evaluation that causing a failure when the width of the scene was greater than the height. This issue was first noted by @naf140230. This is covered by unit tests and I also tested it on a real world problem.

@lewfish lewfish added the review label Dec 14, 2018

@lewfish lewfish changed the title Handle width > height in semseg eval WIP: Handle width > height in semseg eval Dec 14, 2018

@lewfish lewfish force-pushed the lf/to-array branch from 4138413 to 68a9db6 Dec 14, 2018

Handle width > height in semseg eval
Also update unit test for this case

@lewfish lewfish force-pushed the lf/to-array branch from 68a9db6 to 4b7c502 Dec 14, 2018

@lewfish lewfish changed the title WIP: Handle width > height in semseg eval Handle width > height in semseg eval Dec 14, 2018

@lewfish lewfish requested a review from jamesmcclain Dec 14, 2018

@lewfish lewfish referenced this pull request Dec 14, 2018

Closed

arr = np.zeros((extent.ymax, extent.xmax)) #580

1 of 3 tasks complete

@lewfish lewfish merged commit af5604a into develop Dec 17, 2018

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@lewfish lewfish deleted the lf/to-array branch Dec 17, 2018

@lewfish lewfish added needs-backport and removed review labels Dec 17, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.