Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error when using predict packages with AOIs #674

Merged
merged 1 commit into from Feb 4, 2019

Conversation

Projects
None yet
2 participants
@lewfish
Copy link
Contributor

lewfish commented Jan 30, 2019

Overview

This PR makes it so prediction packages based on models trained on scenes containing AOIs will work. It does this by clearing the AOIs from the scene (used as a template) in the prediction package. Without this, the predictor will try to download the AOIs associated with the scene, which will cause an error.

Testing Instructions

This is difficult to test automatically since Predictor is only tested with integration tests and it would require a big change to the integration tests (use of an AOI) to test it. We could also just add unit tests for Predictor, but I think modifying the integration tests to use an AOI is something we ought to do anyway. Added #675

See raster-vision slack for manual testing instructions.

@lewfish lewfish changed the title Fix error when using predict packages with AOIs WIP:Fix error when using predict packages with AOIs Jan 30, 2019

@codecov

This comment has been minimized.

Copy link

codecov bot commented Jan 30, 2019

Codecov Report

Merging #674 into develop will decrease coverage by 0.02%.
The diff coverage is 25%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #674      +/-   ##
===========================================
- Coverage    70.84%   70.81%   -0.03%     
===========================================
  Files          171      171              
  Lines         8131     8135       +4     
===========================================
+ Hits          5760     5761       +1     
- Misses        2371     2374       +3
Impacted Files Coverage Δ
rastervision/predictor.py 15.25% <ø> (ø) ⬆️
rastervision/data/scene_config.py 76.1% <25%> (-1.32%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 01148f3...c13fd18. Read the comment docs.

@lewfish lewfish changed the title WIP:Fix error when using predict packages with AOIs Fix error when using predict packages with AOIs Jan 30, 2019

@lewfish lewfish requested a review from jamesmcclain Jan 30, 2019

@lewfish lewfish assigned lewfish and unassigned lewfish Jan 30, 2019

@lewfish lewfish merged commit 4831f8b into develop Feb 4, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@lewfish lewfish deleted the lf/clear-aois branch Feb 4, 2019

@lewfish lewfish removed the review label Feb 4, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.