Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue with saving semseg predictions for non-georeferenced imagery #708

Merged
merged 1 commit into from Mar 6, 2019

Conversation

Projects
None yet
1 participant
@lewfish
Copy link
Contributor

lewfish commented Mar 6, 2019

This PR fixes an issue with saving semseg predictions for non-georeferenced imagery. It does this by returning None as the transform for the IdentityCRSTransformer.

Tested with:

wget -O spacenet.zip https://s3.amazonaws.com/azavea-research-public-data/raster-vision/examples/model-zoo/vegas-building-seg/predict_package.zip
wget https://content.satimagingcorp.com/static/galleryimages/vatican-city-satellite-image-ikonos-high-resolution.jpg -O example.jpg
rastervision predict spacenet.zip example.jpg out.tif

Closes #707

Return None as transform for IdentityCRSTransformer
This allows saving semantic segmentation predictions when using
non-georeferenced imagery.

@lewfish lewfish force-pushed the lf/ident-transform branch from e659349 to ef33271 Mar 6, 2019

@lewfish lewfish changed the title Return None as transform for IdentityCRSTransformer Fix issue with saving semseg predictions for non-georeferenced imagery Mar 6, 2019

@codecov

This comment has been minimized.

Copy link

codecov bot commented Mar 6, 2019

Codecov Report

Merging #708 into develop will not change coverage.
The diff coverage is 60%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #708   +/-   ##
========================================
  Coverage    71.66%   71.66%           
========================================
  Files          171      171           
  Lines         8283     8283           
========================================
  Hits          5936     5936           
  Misses        2347     2347
Impacted Files Coverage Δ
.../label_store/semantic_segmentation_raster_store.py 15.47% <0%> (ø) ⬆️
...n/data/crs_transformer/rasterio_crs_transformer.py 96.15% <100%> (-0.15%) ⬇️
...stervision/data/crs_transformer/crs_transformer.py 66.66% <66.66%> (+2.38%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9f38cc9...ef33271. Read the comment docs.

@lewfish lewfish merged commit 90f4c5d into develop Mar 6, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@lewfish lewfish deleted the lf/ident-transform branch Mar 6, 2019

@lewfish lewfish removed the review label Mar 6, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.