Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify/clarify/test/validate RasterSource #721

Merged
merged 6 commits into from Mar 25, 2019
Merged

Simplify/clarify/test/validate RasterSource #721

merged 6 commits into from Mar 25, 2019

Conversation

@lewfish
Copy link
Contributor

@lewfish lewfish commented Mar 20, 2019

Overview

This PR does various things to simplify, clarify, test, and validate RasterSource. It also adds validation to the channel order for the predict command, which was the original impetus for this PR. See commits for details.

Testing

Everything is tested by unit and integration tests. I also manually tested with the instructions in #709 which yields the error

> python -m rastervision.cli.main predict potsdam.zip example.jpg out.tif

  File "/opt/src/rastervision/predictor.py", line 145, in predict
    'The predict package is using a channel_order '
ValueError: The predict package is using a channel_order with channels unavailable in the imagery.
To set a new channel_order that only uses channels available in the imagery, use the --channel-order option.

Closes #709

@lewfish lewfish added the review label Mar 20, 2019
@lewfish lewfish force-pushed the lf/no-channel-msg branch 3 times, most recently from 30d2e80 to 0cdb25f Mar 20, 2019
@lewfish lewfish merged commit 7902f11 into develop Mar 25, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@lewfish lewfish deleted the lf/no-channel-msg branch Mar 25, 2019
@lewfish lewfish removed the review label Mar 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant