Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load null channel_order correctly #733

Merged
merged 1 commit into from Mar 27, 2019

Conversation

Projects
None yet
1 participant
@lewfish
Copy link
Contributor

lewfish commented Mar 27, 2019

Overview

Previously, if you saved the config for a RasterSource with a null channel_order (because it was never set) and then loaded it, the channel_order would be set to [] instead of None which would cause problems downstream.

Testing

Added unit test and checked that this fixed problem in #727

Closes #727

@lewfish lewfish force-pushed the lf/no-channel-order branch from 27f8dc7 to e96c0b1 Mar 27, 2019

@lewfish lewfish merged commit 38475ca into master Mar 27, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@lewfish lewfish deleted the lf/no-channel-order branch Mar 27, 2019

@lewfish lewfish removed the review label Mar 27, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.