Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify and improve Docker scripts #743

Merged
merged 1 commit into from Apr 3, 2019

Conversation

Projects
None yet
1 participant
@lewfish
Copy link
Contributor

lewfish commented Apr 3, 2019

Overview

  • Rename console to run since it is now used for various ways of running the
    container
  • Add options for jupyter and docs to run and remove separate scripts
  • Improve usage info and enable run --help
  • Use ./data/ and ./notebooks/ as default directories if corresponding environment
    vars are not set
  • Similar changes were made in azavea/raster-vision-examples#52. The docker scripts in these two directories should be kept as similar as possible.

Testing Instructions

Check all options and also missing env vars.

Closes #742

@lewfish lewfish added the review label Apr 3, 2019

@lewfish lewfish force-pushed the lf/scripts branch from 8312c89 to 385f42f Apr 3, 2019

Unify and improve Docker scripts
* Rename `console` to `run` since it is now used for various ways of running the
container
* Add options for jupyter and docs to `run` and remove separate scripts
* Improve usage info and enable `run --help`
* Use `./data/` and `./notebooks/` as default directories if corresponding environment
vars are not set

@lewfish lewfish force-pushed the lf/scripts branch from 385f42f to 15deb9f Apr 3, 2019

@lewfish lewfish merged commit 7a48457 into master Apr 3, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@lewfish lewfish deleted the lf/scripts branch Apr 3, 2019

@lewfish lewfish removed the review label Apr 3, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.