Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add requester_pays RV config option #762

Merged
merged 2 commits into from Apr 12, 2019

Conversation

Projects
None yet
1 participant
@lewfish
Copy link
Contributor

lewfish commented Apr 12, 2019

Overview

This PR adds a requester_pays option the RV config, which adds support for using requester pays S3 buckets.

[AWS_S3]
requester_pays=True

TODO: See if it's possible to unit test this using moto.

Testing

I tested this by creating a test experiment using NAIP data which is requester pays. I tested it using with requester_pays set to True and False, and did the same with a test project using a non-requester pays S3 bucket.

Closes #682

@lewfish lewfish added the review label Apr 12, 2019

@lewfish lewfish merged commit 2132433 into master Apr 12, 2019

@lewfish lewfish deleted the lf/req-pays branch Apr 12, 2019

@lewfish lewfish removed the review label Apr 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.