Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow type annotations with ConfigBuilders #800

Merged
merged 4 commits into from Jun 19, 2019

Conversation

@jisantuc
Copy link
Member

jisantuc commented Jun 18, 2019

Overview

This PR changes getargspec to getfullargspec so that ConfigBuilders can use functions with type annotations.

Checklist

  • Updated docs/changelog.rst
  • Added needs-backport label if PR is bug fix that applies to previous minor release
  • Ran scripts/format_code and committed any changes
  • Documentation updated if needed
  • PR has a name that won't get you publicly shamed for vagueness

Testing Instructions

  • tests to ensure that nothing broke

Closes #799

jisantuc added 3 commits Jun 18, 2019
Copy link
Member

lossyrob left a comment

Could we get a unit test case that proves this work (would fail on getargspec, passes on getfullargspec)?

There's no test_config.py in tests/core yet, but that's where it would belong.

@jisantuc

This comment has been minimized.

Copy link
Member Author

jisantuc commented Jun 19, 2019

Yes I can write that test. Absence of an existing test_config.py is why I didn't but I definitely know what failure looks like.

@lossyrob

This comment has been minimized.

Copy link
Member

lossyrob commented Jun 19, 2019

Awesome, thank you!

@lossyrob lossyrob merged commit aa98412 into azavea:master Jun 19, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.