Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ZXYRasterSource #812

Closed
wants to merge 4 commits into from
Closed

Add ZXYRasterSource #812

wants to merge 4 commits into from

Conversation

lewfish
Copy link
Contributor

@lewfish lewfish commented Aug 13, 2019

This PR adds a ZXYRasterSource which allows reading imagery from zxy tile servers. It can be configured as follows:

        config = RasterSourceConfig.builder(rv.ZXY_RASTER_SOURCE) \
            .with_tile_schema('http://example.com/{z}/{x}/{y}.png') \
            .with_zoom(18) \
            .with_bounds([min_lat, min_lng, max_lat, max_lng]) \
            .build()

A limitation is that ZXYRasterSources can't be used with the predict command as it is currently implemented. This is because there is an assumption that a RasterSource can be instantiated using a single URI, but the ZXYRasterSource also requires a zoom level and bounds. So, currently this raises a NotImplementedError. This has been tested with unit tests, but still needs a real-world test as part of an experiment.

@lewfish
Copy link
Contributor Author

lewfish commented Sep 20, 2019

We decided it makes more sense to just use the zxy2geotiff script as a data preprocessing script, and not as a type of RasterSource. This will be more efficient (it will only need to be run once rather than every time the chip and predict command run as part of an experiment), and will also simplify the codebase.

@lewfish lewfish closed this Sep 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant