Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix return types for get image blobs funcs #16

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

pheix
Copy link

@pheix pheix commented Sep 18, 2020

Return Str type at MagickGetImageBlob and MagickGetImagesBlob leads to

Malformed UTF-8 at line 1 col 1
  in block MagickGetImageBlob at /opt/rakudo/rakudo-star-2020.05/share/perl6/core/sources/947BDAB9F96E0E5FCCB383124F923A6BF6F8D76B (NativeCall) line 599
  in block <unit> at getimageblob.raku line 31

And these funcs are unable to use. I have added the fix with much more related to origin C-code return types and unit test for MagickGetImageBlob.

Hope to be approved!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant