Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DB restructuring - characters - character_spell & character_spell_cooldown #1171

Closed
FrancescoBorzi opened this issue Dec 29, 2018 · 1 comment

Comments

@FrancescoBorzi
Copy link
Member

FrancescoBorzi commented Dec 29, 2018

This is part of: #1118

General note: not all structure differences can or should be imported. Every change must be first verified. If a structure change is not suitable, we just close the issue.


Last time I've checked, the spell system was different and this change is probably not entirely doable. However it doesn't harm to double check it again.

Fields categoryId and categoryEnd might be used by about an entirely new feature, so they could be added. Investigation is needed.

--- Dumping structure for table acore_characters.character_spell
+-- Dumping structure for table tc_characters.character_spell
 DROP TABLE IF EXISTS `character_spell`;
 CREATE TABLE IF NOT EXISTS `character_spell` (
   `guid` int(10) unsigned NOT NULL DEFAULT '0' COMMENT 'Global Unique Identifier',
   `spell` mediumint(8) unsigned NOT NULL DEFAULT '0' COMMENT 'Spell Identifier',
-  `specMask` tinyint(3) unsigned NOT NULL DEFAULT '1',
+  `active` tinyint(3) unsigned NOT NULL DEFAULT '1',
+  `disabled` tinyint(3) unsigned NOT NULL DEFAULT '0',
   PRIMARY KEY (`guid`,`spell`)
 ) ENGINE=InnoDB DEFAULT CHARSET=utf8 COMMENT='Player System';

--- Dumping structure for table acore_characters.character_spell_cooldown
+-- Dumping structure for table tc_characters.character_spell_cooldown
 DROP TABLE IF EXISTS `character_spell_cooldown`;
 CREATE TABLE IF NOT EXISTS `character_spell_cooldown` (
   `guid` int(10) unsigned NOT NULL DEFAULT '0' COMMENT 'Global Unique Identifier, Low part',
   `spell` mediumint(8) unsigned NOT NULL DEFAULT '0' COMMENT 'Spell Identifier',
   `item` int(10) unsigned NOT NULL DEFAULT '0' COMMENT 'Item Identifier',
   `time` int(10) unsigned NOT NULL DEFAULT '0',
-  `needSend` tinyint(3) unsigned NOT NULL DEFAULT '1',
+  `categoryId` int(10) unsigned NOT NULL DEFAULT '0' COMMENT 'Spell category Id',
+  `categoryEnd` int(10) unsigned NOT NULL DEFAULT '0',
   PRIMARY KEY (`guid`,`spell`)
 ) ENGINE=InnoDB DEFAULT CHARSET=utf8;

--- Dumping structure for table acore_characters.pet_spell_cooldown
+-- Dumping structure for table tc_characters.pet_spell_cooldown
 DROP TABLE IF EXISTS `pet_spell_cooldown`;
 CREATE TABLE IF NOT EXISTS `pet_spell_cooldown` (
   `guid` int(10) unsigned NOT NULL DEFAULT '0' COMMENT 'Global Unique Identifier, Low part',
   `spell` mediumint(8) unsigned NOT NULL DEFAULT '0' COMMENT 'Spell Identifier',
   `time` int(10) unsigned NOT NULL DEFAULT '0',
+  `categoryId` int(10) unsigned NOT NULL DEFAULT '0' COMMENT 'Spell category Id',
+  `categoryEnd` int(10) unsigned NOT NULL DEFAULT '0',
   PRIMARY KEY (`guid`,`spell`)
 ) ENGINE=InnoDB DEFAULT CHARSET=utf8;
@FrancescoBorzi FrancescoBorzi changed the title DB restructuring - characters - character_spell DB restructuring - characters - character_spell & character_spell_cooldown Dec 29, 2018
@FrancescoBorzi
Copy link
Member Author

FrancescoBorzi commented Feb 9, 2019

Probably not applicable since the spell system is different in AC, see: https://github.com/azerothcore/tool-tc-migration/blob/master/4_CLEANUP_AND_CONVERT_SPELLS.sql

Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants