Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EPIC] Align SmartAI to TrinityCore #1326

Open
FrancescoBorzi opened this issue Jan 19, 2019 · 1 comment

Comments

@FrancescoBorzi
Copy link
Member

@FrancescoBorzi FrancescoBorzi commented Jan 19, 2019

This will make easy to exchange SmartAI scripts between AzerothCore and TrinityCore

Global

  • Add missing fields in the table

Event

  • There are some minor difference in Events, shouldn't be an issue. But feel free to investigate.

Action

  • Move SMART_ACTION_SET_SIGHT_DIST to 121

  • Move SMART_ACTION_FLEE to 122

  • Move SMART_ACTION_ADD_THREAT to 123

  • Move SMART_ACTION_LOAD_EQUIPMENT to 124

  • Move SMART_ACTION_TRIGGER_RANDOM_TIMED_EVENT to 125

  • Move SMART_ACTION_REMOVE_ALL_GAMEOBJECTS to 126

  • Remove the remaining extra overlap in enum (after the moves above)

  • Reserve missing enums, display proper error if someone tries to use them

  • SMART_ACTION_ADD_QUEST -> SMART_ACTION_OFFER_QUEST TrinityCore/TrinityCore@ba4d6f6

  • Add param3 to SMART_ACTION_CAST and SMART_ACTION_INVOKER_CAST (but be careful since we already have a param3 there, so maybe add that as param4 ?) TrinityCore/TrinityCore@9072e02

  • Get rid of unused parameter 'storageId' (third) in SMART_ACTION_SUMMON_CREATURE TrinityCore/TrinityCore@a5c248b

  • Reserve smart action 16 TrinityCore/TrinityCore@4e55e79

  • Core/Scripts: Extended SMART_ACTION_SET_INST_DATA to also set BossStates. TrinityCore/TrinityCore@d1d0c64

  • (Optional) cleaning TrinityCore/TrinityCore@84bff76

  • Solve enum conflict SMART_ACTION_SET_DATA vs SMART_ACTION_MOVE_FORWARD

  • Rename SMART_ACTION_SET_FLY to SMART_ACTION_SET_DISABLE_GRAVITY (part of this big commit of Xinef1 TrinityCore/TrinityCore@b0ae5fa)

  • Add missing parameters for SMART_ACTION_MOVE_TO_POS (this and probably others too: TrinityCore/TrinityCore@60d1c0e)

  • Solve SMART_ACTION_ENABLE_TEMP_GOBJ vs SMART_ACTION_RESPAWN_TARGET enum conflict

  • Replace SMART_ACTION_INVOKER_CAST with SMART_ACTION_SELF_CAST in action 85. SMART_ACTION_INVOKER_CAST moves to 134 TrinityCore/TrinityCore@0df3cb5

  • Investigate how SMART_ACTION_JUMP_TO_POS parameters differ

  • Investigate how SMART_ACTION_SET_HOME_POS parameter is different

  • Add missing actions (some of them from the same big commit of Xinef1 mentioned above TrinityCore/TrinityCore@b0ae5fa)

Target

  • Move SMART_TARGET_FARTHEST to 28

  • Reserve missing enums, display proper error if someone tries to use them

  • Implement SMART_TARGET_LOOT_RECIPIENTS

  • Implement SMART_TARGET_VEHICLE_PASSENGER

  • There are more minor differences in Targets, feel free to investigate them.


Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

@ghost

This comment has been minimized.

Copy link

@ghost ghost commented May 7, 2019

Get rid of unused parameter 'storageId' (third) in SMART_ACTION_SUMMON_CREATURE

Checked this and we no longer have storageId

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.