Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(CI): prevent PRs that cause DB errors to get on master #1407

Merged
merged 14 commits into from Feb 6, 2019

Conversation

@FrancescoBorzi
Copy link
Member

FrancescoBorzi commented Feb 3, 2019

  1. Implemented dry run using worldserver --dry-run.

By running in this mode, the core will:

  • only require dbc files, config and connection to DB to run
  • no maps/vmaps/mmaps required
  • it will terminate after loading all the dbc and DB data

Useful to quickly check if the worldserver starting run is generating DB errors. This will be used in CI.


  1. Implemented a script for the travis CI that checks whether there are startup DB errors. If there are, fail the build.

image

image


Closes #1154

@Viste
Viste approved these changes Feb 4, 2019
@Deku

This comment has been minimized.

Copy link
Contributor

Deku commented Feb 4, 2019

Are you planning on implementing Travis modifications in another PR? Because it could be here, so everything is packed in one single update.

@BarbzYHOOL

This comment has been minimized.

Copy link
Member

BarbzYHOOL commented Feb 4, 2019

Awesome

@Helias
Helias approved these changes Feb 4, 2019
@Winfidonarleyan

This comment has been minimized.

Copy link
Member

Winfidonarleyan commented Feb 5, 2019

Perfect

data/travis/worldserver.conf Outdated Show resolved Hide resolved
@FrancescoBorzi FrancescoBorzi changed the title feat: implemented AC dry-run feat(CI): prevent PR causing startup DB errors to get on master Feb 6, 2019
@FrancescoBorzi FrancescoBorzi changed the title feat(CI): prevent PR causing startup DB errors to get on master feat(CI): prevent PR causing DB errors to get on master Feb 6, 2019
Copy link
Member

Stoabrogga left a comment

Looks good 👍

@FrancescoBorzi FrancescoBorzi merged commit 7b61731 into azerothcore:master Feb 6, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@FrancescoBorzi FrancescoBorzi deleted the FrancescoBorzi:dry-run branch Feb 6, 2019
@FrancescoBorzi FrancescoBorzi changed the title feat(CI): prevent PR causing DB errors to get on master feat(CI): prevent PRs that cause DB errors to get on master Feb 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
8 participants
You can’t perform that action at this time.