Core: Added ABORT() macro to prevent the usage of ASSERT(false) as a quick hack to crash the core misusing assert

[Viste]

CHANGES PROPOSED:

• add ABORT macros

Target branch(es):

• master

[Viste]

@milestorme dont cry baby we love you to :)))

[Viste]

so what about review or something?

[ghost]

I'm sorry, but I can't do this because I don't know what this is about, why we need this or what this affects. I'm not good at C++.

[Viste]

I'm sorry, but I can't do this because I don't know what this is about, why we need this or what this affects. I'm not good at C++.

to prevent the usage of ASSERT(false) as a quick hack to crash the core

[ghost]

Yes, I read that, but I don't understand why it is bad to use ASSERT(false). You also added some changes to Errors.cpp and Errors.h that I also don't understand.

[ghost]

As I told, I'm quite a noob at C++, sorry.

[Viste]

For better formatting(human readable) and ace replace :)

[PkllonG]

I didn't know how to test it, so I'll use it on my server.

[FrancescoBorzi]

@pklloveyou that will be enough, thanks

[PkllonG]

The server was running for 24 hours with no errors found

[Winfidonarleyan]

Test in win at VS 16.2. Perfect work

C:\Users\Kargatum\Desktop\D\Core\Azeroth>authserver.exe
AzerothCore rev. 24ba6797449c+ 2019-09-07 06:40:16 +0300 (ass branch) (Win64, RelWithDebInfo) (authserver)
<Ctrl-C> to stop.

   █████╗ ███████╗███████╗██████╗  ██████╗ ████████╗██╗  ██╗
  ██╔══██╗╚══███╔╝██╔════╝██╔══██╗██╔═══██╗╚══██╔══╝██║  ██║
  ███████║  ███╔╝ █████╗  ██████╔╝██║   ██║   ██║   ███████║
  ██╔══██║ ███╔╝  ██╔══╝  ██╔══██╗██║   ██║   ██║   ██╔══██║
  ██║  ██║███████╗███████╗██║  ██║╚██████╔╝   ██║   ██║  ██║
  ╚═╝  ╚═╝╚══════╝╚══════╝╚═╝  ╚═╝ ╚═════╝    ╚═╝   ╚═╝  ╚═╝
                                ██████╗ ██████╗ ██████╗ ███████╗
                                ██╔════╝██╔═══██╗██╔══██╗██╔═══╝
                                ██║     ██║   ██║██████╔╝█████╗
                                ██║     ██║   ██║██╔══██╗██╔══╝
                                ╚██████╗╚██████╔╝██║  ██║███████╗
                                 ╚═════╝ ╚═════╝ ╚═╝  ╚═╝╚══════╝

          AzerothCore 3.3.5a  -  www.azerothcore.org

Using configuration file authserver.conf.

C:\Git\azerothcore-wotlk\src\server\authserver\Main.cpp:131 in ace_main_i ABORTED.