Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Cmake): set minimal support version 3.8 #2295

Merged
merged 1 commit into from Sep 21, 2019

Conversation

@Winfidonarleyan
Copy link
Member

commented Sep 20, 2019

CHANGES PROPOSED:
TESTS PERFORMED:
  • Configure in Linux
HOW TO TEST THE CHANGES:
  • Build this
KNOWN ISSUES AND TODO LIST:
  • [ ]
Target branch(es):
  • Master

How to test AzerothCore PRs

When a PR is ready to be tested, it will be marked as [WAITING TO BE TESTED].

You can help by testing PRs and writing your feedback here in the PR's page on GitHub. Follow the instructions here:

http://www.azerothcore.org/wiki/How-to-test-a-PR

@FrancescoBorzi

This comment has been minimized.

Copy link
Member

commented Sep 20, 2019

@Winfidonarleyan please have a look at the Travis build

@Winfidonarleyan Winfidonarleyan added the WIP label Sep 20, 2019
… for world and auth

* Added interface library authserver-interface
* Added interfaca library worldserver-interface
* Added Copyright's in auth and world server Cmake's files
@Winfidonarleyan Winfidonarleyan force-pushed the Winfidonarleyan:cmake-ver branch from 7b8cb8f to 2775f97 Sep 21, 2019
@pklloveyou

This comment has been minimized.

Copy link

commented Sep 21, 2019

Build success

@Winfidonarleyan

This comment has been minimized.

Copy link
Member Author

commented Sep 21, 2019

Thanks for test

@Winfidonarleyan Winfidonarleyan merged commit 3518c9e into azerothcore:master Sep 21, 2019
2 checks passed
2 checks passed
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@Winfidonarleyan Winfidonarleyan deleted the Winfidonarleyan:cmake-ver branch Sep 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.