Added history viewing for previous executions on the schedule graph #21

Merged
merged 2 commits into from May 23, 2013

Conversation

Projects
None yet
2 participants
Contributor

lishid commented May 22, 2013

No description provided.

@@ -277,4 +277,12 @@ public static Object invokeStaticMethod(ClassLoader loader, String className, St
Method method = clazz.getDeclaredMethod(methodName, argTypes);
return method.invoke(null, args);
}
+
@rbpark

rbpark May 23, 2013

Collaborator

Use IOUtils instead

+ JSONUtils.toJSON(ret, new SplitterOutputStream(cacheOutput, resp.getOutputStream()), false);
+ // System.out.println("Writing cache file for " + start);
+ // JSONUtils.toJSON(ret, new JSONCompressorOutputStream(resp.getOutputStream()), false);
+
@rbpark

rbpark May 23, 2013

Collaborator

Call close on stream

+
+ private void ajaxLoadHistory(HttpServletRequest req, HttpServletResponse resp, User user) throws ServletException, IOException {
+ resp.setContentType(JSON_MIME_TYPE);
+ long today = DateTime.now().withTime(0, 0, 0, 0).getMillis();
@rbpark

rbpark May 23, 2013

Collaborator

Use utc

+ int loadAll = getIntParam(req, "loadAll");
+
+ // Cache file
+ File cache = new File("cache/schedule-history/" + startTime + ".cache");
@rbpark

rbpark May 23, 2013

Collaborator

cache directory should in properties.

+ if (cacheExists) {
+ // Send the cache instead
+ InputStream cacheInput = new FileInputStream(cache);
+ Utils.copyStream(cacheInput, resp.getOutputStream());
@rbpark

rbpark May 23, 2013

Collaborator

BufferInputStream on every file inputstream

+ ExecutorManager executorManager = server.getExecutorManager();
+ history = executorManager.getExecutableFlows(null, null, null, 0, startTime, endTime, -1, -1);
+ } catch (ExecutorManagerException e) {
+ // Return empty should suffice
@rbpark

rbpark May 23, 2013

Collaborator

Change behaviour. Probably should do something here.

Collaborator

rbpark commented May 23, 2013

Merging the patch. Please fix the noted pieces of code.

rbpark added a commit that referenced this pull request May 23, 2013

Merge pull request #21 from lishd/master
Added history viewing for previous executions on the schedule graph

@rbpark rbpark merged commit 46d3041 into azkaban:master May 23, 2013

erwa pushed a commit to erwa/azkaban that referenced this pull request Jul 25, 2016

Merge pull request #21 from davidzchen/bootstrap_ui
Plumb Job Conf for Pig Visualizer
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment