Issue #90 breaks rendering #93

Closed
diddledan opened this Issue Mar 28, 2013 · 4 comments

Comments

Projects
None yet
5 participants

Issue #90 introduced body tag injection, and was merged in commit 0cca61b.

This has caused a problem in my own project where the code is incorrectly adding a second body tag, which causes my css to be applied incorrectly. I propose to revert this commit or fix the injection. For now I need to use a older version of the script.

flop commented Apr 8, 2013

Just got a similar problem just by putting

<script src="jquery.overscroll.js"></script>

in my

<head></head>

Colir commented Apr 24, 2013

Load it in your body

@azoff azoff added this to the 1.7.4 milestone Feb 12, 2014

Owner

azoff commented Feb 12, 2014

This'll be fixed in 1.7.4, the compat code is now lazy-loaded.

@azoff azoff closed this Feb 12, 2014

azoff pushed a commit that referenced this issue Feb 12, 2014

Jonathan Azoff
1.7.4 Release
- Adds source map to compiled output
- Removes legacy `demo.html`
- Drops IE<9 support
- Updates License and Copyright
- Changes compat to be lazy-loaded and memoized. Closes #98. Fixes #91
- Fixes formatting in test files
- Adds `thumbColor` option, to allow user-defined thumb colors. Closes #102
- Adds, and removes, a DOM body if required for testing. Closes #93

azoff pushed a commit that referenced this issue Feb 12, 2014

Jonathan Azoff
1.7.4 Release
- Adds source map to compiled output
- Removes legacy `demo.html`
- Drops IE<9 support
- Updates License and Copyright
- Changes compat to be lazy-loaded and memoized. Closes #98. Fixes #91
- Fixes formatting in test files
- Adds `thumbColor` option, to allow user-defined thumb colors. Closes #102
- Adds, and removes, a DOM body if required for testing. Closes #93

Thanks by the update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment