Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Push some fix for overscroll #24

Merged
merged 2 commits into from Jul 25, 2011

Conversation

Projects
None yet
2 participants
Contributor

googollee commented Jul 22, 2011

Hi azoff,

Thanks for making such good thing.

I just fix two issue when I use it:

  • The scroll thumb can't go to the right/bottom.

Basically, the calculation in moveThumb has included the width/height of container and the left/top will never be the same as the width/height of scrolling size. So it's no need to exclude the container size when calculate the scrolling size.

  • The scrolling content may overlay the thumb.

To avoid the thumb overlaid with scrolling content, make the thumb's z-index to 1.

Hope the fix can help the overscroll better.

@azoff azoff pushed a commit that referenced this pull request Jul 25, 2011

Jonathan Azoff Merge pull request #24 from googollee/master
Merging fix from googolee branch
23610a9

@azoff azoff merged commit 23610a9 into azoff:master Jul 25, 2011

Owner

azoff commented Jul 25, 2011

Thanks man!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment