error: struct field shorthands are unstable (see issue #37340)

[matthiasbock]

I attempted to build the current HEAD on branch master (commit 628e60a), but it fails with an error:

openfpga/build $ cmake ..
-- The C compiler identification is GNU 7.3.0
-- The CXX compiler identification is GNU 7.3.0
-- Check for working C compiler: /usr/lib/ccache/cc
-- Check for working C compiler: /usr/lib/ccache/cc -- works
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Detecting C compile features
-- Detecting C compile features - done
-- Check for working CXX compiler: /usr/lib/ccache/c++
-- Check for working CXX compiler: /usr/lib/ccache/c++ -- works
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- pdflatex found, documentation will be built
-- Rust enabled
-- Configuring done
-- Generating done
-- Build files have been written to: openfpga/build
openfpga/build $ make
Scanning dependencies of target xc2par
    Updating registry `https://github.com/rust-lang/crates.io-index`
 Downloading serde v1.0.79
 Downloading slog-stdlog v3.0.2
 Downloading clap v2.32.0
 Downloading slog-term v2.4.0
 Downloading serde_derive v1.0.79
 Downloading slog v2.4.0
 Downloading serde_json v1.0.31
 Downloading rand v0.3.22
 Downloading syn v0.15.8
 Downloading quote v0.6.8
 Downloading proc-macro2 v0.4.19
 Downloading unicode-xid v0.1.0
 Downloading quote v0.5.2
 Downloading syn v0.13.11
 Downloading proc-macro2 v0.3.8
 Downloading itoa v0.4.3
 Downloading ryu v0.2.6
 Downloading crossbeam v0.2.12
 Downloading slog-scope v4.0.1
 Downloading log v0.3.9
 Downloading lazy_static v0.2.11
 Downloading log v0.4.5
 Downloading cfg-if v0.1.5
 Downloading bitflags v1.0.4
 Downloading atty v0.2.11
 Downloading unicode-width v0.1.5
 Downloading vec_map v0.8.1
 Downloading textwrap v0.10.0
 Downloading strsim v0.7.0
 Downloading thread_local v0.3.6
 Downloading isatty v0.1.9
 Downloading chrono v0.4.6
 Downloading term v0.5.1
 Downloading lazy_static v1.1.0
 Downloading version_check v0.1.5
 Downloading num-traits v0.2.6
 Downloading num-integer v0.1.39
 Downloading time v0.1.40
 Downloading libc v0.2.43
 Downloading byteorder v1.2.6
 Downloading rand v0.4.3
 Downloading ansi_term v0.11.0
   Compiling bitflags v1.0.4
   Compiling byteorder v1.2.6
   Compiling strsim v0.7.0
   Compiling proc-macro2 v0.4.19
   Compiling unicode-width v0.1.5
   Compiling jedec v0.0.2 (openfpga/src/jedec)
error: struct field shorthands are unstable (see issue #37340)
   --> openfpga/src/jedec/src/lib.rs:386:13
    |
386 |             f,
    |             ^

error: aborting due to previous error

Build failed, waiting for other jobs to finish...
error: Could not compile `jedec`.

To learn more, run the command again with --verbose.
src/CMakeFiles/xc2par.dir/build.make:57: recipe for target 'src/CMakeFiles/xc2par' failed
make[2]: *** [src/CMakeFiles/xc2par] Error 101
CMakeFiles/Makefile2:119: recipe for target 'src/CMakeFiles/xc2par.dir/all' failed
make[1]: *** [src/CMakeFiles/xc2par.dir/all] Error 2
Makefile:140: recipe for target 'all' failed
make: *** [all] Error 2

[matthiasbock]

I resolved the problem by upgrading the Rust compiler. Apparently, to resolve this issue, at least version 1.17.0 is required. Maybe this can be noted somewhere, e.g. in CMakeLists.txt(?) Not sure, if or how the latter can be done though.