Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix incorrect result about lerna 7+ #70

Merged
merged 1 commit into from
Jul 7, 2023

Conversation

azu
Copy link
Owner

@azu azu commented Jul 7, 2023

lerna v7 deleted useWorkspaces.
https://github.com/lerna/lerna/blob/e9796f1770baefb33d49c101d46095b47151f7c1/CHANGELOG.md?plain=1#L51

This change affetect packages/@monorepo-utils/package-utils/src/get-packages.ts.

If you used lerna.json without useWorkspaces, this monorepo tool could not found correct packages.

This PR fix incorrect result about lerna 7+.

@azu azu added the Type: Bug Bug or Bug fixes label Jul 7, 2023
@azu azu linked an issue Jul 7, 2023 that may be closed by this pull request
@azu azu merged commit 2f1d7d0 into master Jul 7, 2023
@azu azu deleted the 69-lernajson-exists-but-use-packagejsons-workspaces branch July 7, 2023 12:27
@github-actions github-actions bot mentioned this pull request Jul 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Bug or Bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

lerna.json exists, but use package.json's workspaces
1 participant