Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add England, Wales, Scotland, Northern Ireland #166

Merged
merged 13 commits into from Sep 19, 2019

Conversation

c960657
Copy link
Contributor

@c960657 c960657 commented Sep 1, 2019

Public holidays are defined differently in England, Wales, Northern Ireland and particularly Scotland.

I have tried to implement providers for each of these countries based on Wikipedia (UK and Scotland), official sources (1, 2, 3), newspaper articles (4, 5) and other online sources (6, 7).

The providers for England and Wales are identical to the existing United Kingdom provider, including the unit tests. The provider for Northern Ireland is nearly identical except that it adds to holidays. The provider for Scotland is completely different (it does not call parent::initialize().

Northern Ireland did not exist as a country prior to 1921 (neither did the Republic of Ireland), but I haven't added special handling of this. I assume that the territory that is currently Northern Ireland followed the same rules as England and Wales prior to then.

Like the United Kingdom provider, these providers miss translations for substitute holidays. This issue has been addressed in PR #162.

CHANGELOG.md Outdated Show resolved Hide resolved
@stelgenhof stelgenhof added this to the v2.2.0 milestone Sep 18, 2019
@stelgenhof
Copy link
Member

Hi @c960657
I am reviewing this PR and like to include it in the next v2.2 release that I am planning (likely before the end of this month). Would you like to use the SubstituteHoliday class in this PR or merge it without?

Cheers! Sacha

@c960657
Copy link
Contributor Author

c960657 commented Sep 19, 2019

I merged the SubstituteHoliday change into the united-kingdom branch a few days ago, but I did not realise that this branch introduces some new substitute holidays that should be updated to the new pattern.

It's fixed now :-)

@stelgenhof stelgenhof merged commit c0057a6 into azuyalabs:develop Sep 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants