Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump dependency versions to resolve full mode access token refresh issues #93

Merged
merged 2 commits into from Sep 6, 2019

Conversation

blitz-1306
Copy link
Collaborator

@blitz-1306 blitz-1306 commented Sep 6, 2019

Brief

Recently MythXJS released version 1.3.5 to address BUG in access token refresh logic. Also truffle packages switched to use new naming policy. This PR proposes to bump dependencies and fix issues, also switch deprecated package names of truffle dependencies to new ones.

Status

Stable.

Changes

Regards, @blitz-1306.

…package names for deprecated dependencies and bumped their versions.
@blitz-1306 blitz-1306 changed the title Bump dependency versions to resolve full mode token refresh issues Bump dependency versions to resolve full mode access token refresh issues Sep 6, 2019
@muellerberndt
Copy link
Owner

This resolves the refresh issue.

@blitz-1306 full mode scans usually take around a full 30 minutes to complete, but might also take longer depending on API load. I suggest we also change the timeout settings for full mode to:

  initialDelay = 1800 * 1000;
  timeout = 5400 * 1000;

Copy link
Owner

@muellerberndt muellerberndt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment

@blitz-1306
Copy link
Collaborator Author

@b-mueller see 6a85324

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants