Switch to a common BuildFactory creation function #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are minor differences between build steps but they are mostly the same. The configuration file gets inconsistent very easily due to so many duplicated BuildFactories. Extract common BuildFactory setup code into create_build_factory(). Things to consider: * Git repository URL * Git branch * make(1) program name (e.g. gmake on OpenBSD and Solaris) * ./configure arguments * Out-of-tree builds using a separate directory Locks are used to avoid hammering the git servers. Automatically find locks based on the git repository URL. This saves us from specifying the right lock variable for each BuildFactory. This patch also runs "make check" on each BuildFactory. This has been requested by submaintainers who found their pull requests broke "make check" - they'd like to find out earlier so run it on each BuildFactory, not just the qemu.git/master default one. Signed-off-by: Stefan Hajnoczi <stefanha@gmail.com>
ghost
assigned
berendt
added a commit
that referenced
this pull request
Feb 1, 2013
Switch to a common BuildFactory creation function
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WARNING: I have not tested this patch but I hope you find the changes worthwhile enough to try them out and merge it.
There are minor differences between build steps but they are mostly the
same. The configuration file gets inconsistent very easily due to so
many duplicated BuildFactories.
Extract common BuildFactory setup code into create_build_factory().
Things to consider:
Locks are used to avoid hammering the git servers. Automatically find
locks based on the git repository URL. This saves us from specifying
the right lock variable for each BuildFactory.
This patch also runs "make check" on each BuildFactory. This has been
requested by submaintainers who found their pull requests broke "make
check" - they'd like to find out earlier so run it on each BuildFactory,
not just the qemu.git/master default one.
Signed-off-by: Stefan Hajnoczi stefanha@gmail.com