Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/list all accounts endpoint #119

Merged
merged 6 commits into from Jun 25, 2019
Merged

Conversation

@daltonmatos
Copy link
Member

daltonmatos commented Jun 24, 2019

No description provided.

daltonmatos added 3 commits Jun 24, 2019
Esse endpoint lista todas as contas de um cluster Asgard. Por enquanto
qualquer usuário autenticado consegue fazer essa listagem. Precisamos
pensar em algo relacionado a permissionamento.
@codecov

This comment has been minimized.

Copy link

codecov bot commented Jun 24, 2019

Codecov Report

Merging #119 into master will increase coverage by 0.07%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #119      +/-   ##
==========================================
+ Coverage   90.38%   90.45%   +0.07%     
==========================================
  Files          84       85       +1     
  Lines        2309     2327      +18     
  Branches       87       92       +5     
==========================================
+ Hits         2087     2105      +18     
  Misses        211      211              
  Partials       11       11
Flag Coverage Δ
#typehint 29.41% <30.76%> (+0.06%) ⬆️
#unittest 94.79% <100%> (+0.04%) ⬆️
Impacted Files Coverage Δ
asgard/models/base.py 96% <ø> (ø) ⬆️
asgard/models/account.py 68.18% <ø> (-0.71%) ⬇️
asgard/api/resources/accounts.py 100% <100%> (ø)
asgard/services/accounts.py 100% <100%> (ø) ⬆️
asgard/api/accounts.py 93.54% <100%> (+1.54%) ⬆️
asgard/backends/accounts.py 89.47% <100%> (+3.75%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2ef0c22...56afe0f. Read the comment docs.

@daltonmatos

This comment has been minimized.

Copy link
Member Author

daltonmatos commented Jun 24, 2019

daltonmatos added 2 commits Jun 25, 2019
@daltonmatos daltonmatos merged commit 56afe0f into master Jun 25, 2019
7 checks passed
7 checks passed
ci/circleci: py368 Your tests passed on CircleCI!
Details
ci/circleci: py36x Your tests passed on CircleCI!
Details
ci/circleci: py37x Your tests passed on CircleCI!
Details
codecov/patch/typehint 30.76% of diff hit (target 29.34%)
Details
codecov/patch/unittest 100% of diff hit (target 94.75%)
Details
codecov/project/typehint 29.41% (+0.06%) compared to 2ef0c22
Details
codecov/project/unittest 94.79% (+0.04%) compared to 2ef0c22
Details
@daltonmatos daltonmatos deleted the feature/list-all-accounts-endpoint branch Jun 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant
You can’t perform that action at this time.