Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adicionando flag `unittest` para o coverage dos testes #121

Merged
merged 8 commits into from Jun 25, 2019

Conversation

@daltonmatos
Copy link
Member

daltonmatos commented Jun 24, 2019

No description provided.

@codecov

This comment has been minimized.

Copy link

codecov bot commented Jun 24, 2019

Codecov Report

Merging #121 into master will decrease coverage by 4.37%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #121      +/-   ##
==========================================
- Coverage   94.75%   90.38%   -4.38%     
==========================================
  Files          84       84              
  Lines        2155     2309     +154     
  Branches        0       87      +87     
==========================================
+ Hits         2042     2087      +45     
- Misses        113      211      +98     
- Partials        0       11      +11
Flag Coverage Δ
#typehint 29.34% <ø> (?)
#unittest 94.75% <ø> (?)
Impacted Files Coverage Δ
asgard/models/user_has_account.py 42.85% <0%> (-57.15%) ⬇️
asgard/backends/users.py 63.63% <0%> (-36.37%) ⬇️
asgard/http/client.py 67.56% <0%> (-32.44%) ⬇️
asgard/models/account.py 68.88% <0%> (-31.12%) ⬇️
asgard/backends/mesos/models/agent.py 76.92% <0%> (-20.52%) ⬇️
asgard/api/users.py 81.81% <0%> (-18.19%) ⬇️
asgard/backends/accounts.py 85.71% <0%> (-14.29%) ⬇️
asgard/api/agents.py 67.74% <0%> (-14.08%) ⬇️
asgard/http/auth/auth_required.py 82.72% <0%> (-13.98%) ⬇️
asgard/http/auth/jwt.py 87.5% <0%> (-12.5%) ⬇️
... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ab665f9...f7295bd. Read the comment docs.

daltonmatos added 7 commits Jun 24, 2019
A tentativa é substituir esse status pelo `codecov/project/unittest`.
Tentando fazer com que as comparações sejam feitas com a branch base.
Atualmente o codecov está assumindo target=100%
Como a master não tem report para os status que estão sendo criados,
acredito que por isso a comparação não está sendo feita. Apesar de ter a
impressão de já ter visto o codecov "não cobrar" o check quando a base
branch ainda não possui um valor para ser comparado.
Vamos mergear para a master e ver se isso faz com que novos PRs façam os
cálculos corretamente.
@daltonmatos daltonmatos merged commit f7295bd into master Jun 25, 2019
5 of 7 checks passed
5 of 7 checks passed
codecov/project/typehint 29.34% (-70.66%) compared to ab665f9
Details
codecov/project/unittest 94.75% (-5.25%) compared to ab665f9
Details
ci/circleci: py368 Your tests passed on CircleCI!
Details
ci/circleci: py36x Your tests passed on CircleCI!
Details
ci/circleci: py37x Your tests passed on CircleCI!
Details
codecov/patch/typehint Coverage not affected when comparing ab665f9...f7295bd
Details
codecov/patch/unittest Coverage not affected when comparing ab665f9...f7295bd
Details
@daltonmatos daltonmatos deleted the feature/codecov-unittest-flag branch Jun 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant
You can’t perform that action at this time.