Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5] Update Docs, explicação sobre ModelConverterInterface #144

Conversation

@daltonmatos
Copy link
Member

daltonmatos commented Jul 22, 2019

Documentanto os novos modelos e como o código está organizado com essa nova implementação do ScheduledJobsBackend.

daltonmatos added 2 commits Jul 22, 2019
Explica a nova arquitetura de models e ModelConverters.
Atualiza pontos onde o Chronos pode ser mencionado.
@codecov

This comment has been minimized.

Copy link

codecov bot commented Jul 22, 2019

Codecov Report

Merging #144 into feature/scheduled-jobs-get-job-by-id will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@                          Coverage Diff                          @@
##           feature/scheduled-jobs-get-job-by-id     #144   +/-   ##
=====================================================================
  Coverage                                 88.96%   88.96%           
=====================================================================
  Files                                       101      101           
  Lines                                      3008     3008           
  Branches                                    166      166           
=====================================================================
  Hits                                       2676     2676           
  Misses                                      319      319           
  Partials                                     13       13
Flag Coverage Δ
#typehint 44.15% <ø> (ø) ⬆️
#unittest 92.9% <ø> (ø) ⬆️
Impacted Files Coverage Δ
asgard/backends/models/converters.py 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b19c861...442cf86. Read the comment docs.

@daltonmatos daltonmatos merged commit 442cf86 into feature/scheduled-jobs-get-job-by-id Jul 23, 2019
7 checks passed
7 checks passed
ci/circleci: py368 Your tests passed on CircleCI!
Details
ci/circleci: py36x Your tests passed on CircleCI!
Details
ci/circleci: py37x Your tests passed on CircleCI!
Details
codecov/patch/typehint Coverage not affected when comparing b19c861...442cf86
Details
codecov/patch/unittest Coverage not affected when comparing b19c861...442cf86
Details
codecov/project/typehint 44.15% remains the same compared to b19c861
Details
codecov/project/unittest 92.9% remains the same compared to b19c861
Details
@daltonmatos daltonmatos deleted the feature/update-doc-model-converters branch Jul 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant
You can’t perform that action at this time.