Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DELETE /jobs/{job_id} #153

Merged

Conversation

@daltonmatos
Copy link
Member

daltonmatos commented Jul 30, 2019

No description provided.

daltonmatos added 3 commits Jul 30, 2019
@codecov

This comment has been minimized.

Copy link

codecov bot commented Jul 30, 2019

Codecov Report

Merging #153 into feature/scheduled-jobs-update will increase coverage by 0.01%.
The diff coverage is 93.02%.

Impacted file tree graph

@@                        Coverage Diff                        @@
##           feature/scheduled-jobs-update     #153      +/-   ##
=================================================================
+ Coverage                          91.62%   91.63%   +0.01%     
=================================================================
  Files                                104      104              
  Lines                               3165     3205      +40     
  Branches                             194      204      +10     
=================================================================
+ Hits                                2900     2937      +37     
- Misses                               252      255       +3     
  Partials                              13       13
Flag Coverage Δ
#typehint 44.41% <42.85%> (-0.04%) ⬇️
#unittest 95.77% <97.29%> (+0.01%) ⬆️
Impacted Files Coverage Δ
asgard/backends/jobs.py 100% <100%> (ø) ⬆️
asgard/http/exceptions.py 100% <100%> (ø) ⬆️
asgard/services/jobs.py 100% <100%> (ø) ⬆️
asgard/backends/chronos/impl.py 100% <100%> (ø) ⬆️
asgard/api/jobs.py 90.19% <85.71%> (-0.72%) ⬇️
asgard/clients/chronos/client.py 91.89% <87.5%> (-1.45%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b2b8ec9...1a6834b. Read the comment docs.

Deve apenas retornar um HTTP e a exception deve ser lançada pelo código
do backend.

O ajuste aqui foi apenas no mock, o código estava correto
daltonmatos added 2 commits Jul 30, 2019
Essa implementação é um paliativo enquando nao refazemos a API do
`asgard.http.client`. Quando fizermos essa re-implementação poderemos
voltar a usar o client padrão aqui.
daltonmatos added 5 commits Jul 31, 2019
A auth vem de uma nova envvar: SCHEDULED_JOBS_SERVICE_AUTH
Dessa forma evitamos os `.split(":")` e deixamos a validação para o
Pydantic, pagando o preço de ter uma envvar com um conteúdo mais complexo.
@pabrrs
pabrrs approved these changes Aug 1, 2019
daltonmatos added 2 commits Aug 1, 2019
O código não estava checando se a env já existe antes de setar o valor
final
…s-jobs-delete
@daltonmatos daltonmatos merged commit 1a6834b into feature/scheduled-jobs-update Aug 1, 2019
0 of 3 checks passed
0 of 3 checks passed
ci/circleci: py368 CircleCI is running your tests
Details
ci/circleci: py36x CircleCI is running your tests
Details
ci/circleci: py37x Your tests are queued behind your running builds
Details
@daltonmatos daltonmatos deleted the feature/schedules-jobs-delete branch Aug 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.