Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/chronos client with auth #154

Merged

Conversation

@daltonmatos
Copy link
Member

daltonmatos commented Jul 31, 2019

Implementação temporária, até corrigirmos a API do http_client que temos hoje no código.

daltonmatos added 2 commits Jul 30, 2019
Essa implementação é um paliativo enquando nao refazemos a API do
`asgard.http.client`. Quando fizermos essa re-implementação poderemos
voltar a usar o client padrão aqui.
@codecov

This comment has been minimized.

Copy link

codecov bot commented Jul 31, 2019

Codecov Report

Merging #154 into feature/schedules-jobs-delete will increase coverage by 0.07%.
The diff coverage is 95.74%.

Impacted file tree graph

@@                        Coverage Diff                        @@
##           feature/schedules-jobs-delete     #154      +/-   ##
=================================================================
+ Coverage                          91.63%   91.71%   +0.07%     
=================================================================
  Files                                104      104              
  Lines                               3205     3221      +16     
  Branches                             204      209       +5     
=================================================================
+ Hits                                2937     2954      +17     
+ Misses                               255      254       -1     
  Partials                              13       13
Flag Coverage Δ
#typehint 45.15% <68.29%> (+0.73%) ⬆️
#unittest 95.79% <100%> (+0.02%) ⬆️
Impacted Files Coverage Δ
asgard/backends/chronos/impl.py 100% <100%> (ø) ⬆️
asgard/conf.py 100% <100%> (ø) ⬆️
asgard/clients/chronos/client.py 95.74% <94.59%> (+3.85%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cadc104...bc49826. Read the comment docs.

A auth vem de uma nova envvar: SCHEDULED_JOBS_SERVICE_AUTH
@pabrrs
pabrrs approved these changes Jul 31, 2019
daltonmatos added 5 commits Jul 31, 2019
Dessa forma evitamos os `.split(":")` e deixamos a validação para o
Pydantic, pagando o preço de ter uma envvar com um conteúdo mais complexo.
O código não estava checando se a env já existe antes de setar o valor
final
@daltonmatos daltonmatos merged commit bc49826 into feature/schedules-jobs-delete Aug 1, 2019
7 checks passed
7 checks passed
ci/circleci: py368 Your tests passed on CircleCI!
Details
ci/circleci: py36x Your tests passed on CircleCI!
Details
ci/circleci: py37x Your tests passed on CircleCI!
Details
codecov/patch/typehint 68.29% of diff hit (target 44.41%)
Details
codecov/patch/unittest 100% of diff hit (target 95.77%)
Details
codecov/project/typehint 45.15% (+0.73%) compared to cadc104
Details
codecov/project/unittest 95.79% (+0.02%) compared to cadc104
Details
@daltonmatos daltonmatos deleted the feature/chronos-client-with-auth branch Aug 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.