Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Versão inicial do novo client http #167

Merged
merged 8 commits into from Aug 15, 2019
Merged

Versão inicial do novo client http #167

merged 8 commits into from Aug 15, 2019

Conversation

@daltonmatos
Copy link
Member

daltonmatos commented Aug 12, 2019

O próximo passo é migrar algum código que usava o client antigo. Dessa
forma vamos vendo se valtou alguma coisa.

O próximo passo é migrar algum código que usava o client antigo. Dessa
forma vamos vendo se valtou alguma coisa.
@codecov

This comment has been minimized.

Copy link

codecov bot commented Aug 12, 2019

Codecov Report

Merging #167 into master will increase coverage by 0.05%.
The diff coverage is 92.66%.

Flag Coverage Δ
#typehint 44.65% <45.12%> (-0.3%) ⬇️
#unittest 96.29% <100%> (ø) ⬆️
Impacted Files Coverage Δ
asgard/backends/mesos/client/impl.py 96.77% <100%> (+3.02%) ⬆️
asgard/http/exceptions.py 100% <100%> (ø) ⬆️
asgard/clients/chronos/client.py 100% <100%> (+4.25%) ⬆️
asgard/backends/mesos/models/agent.py 77.35% <87.5%> (+0.43%) ⬆️
asgard/http/client.py 76.98% <90.38%> (+8.56%) ⬆️
asgard/backends/chronos/impl.py 98.63% <0%> (-1.37%) ⬇️
daltonmatos added 7 commits Aug 13, 2019
Não usamos diretamente as exceptions do aiohtto pois não dá para criar
uma instãncia passando os dados que precisamos.

Nossas exceptions herdam das do aiohttp apenas para pegar o atributo
`status_code`. Podemos até repensar isso e ver se vale a pena essa
herança.
@daltonmatos daltonmatos merged commit 4b55fb4 into master Aug 15, 2019
7 checks passed
7 checks passed
ci/circleci: py368 Your tests passed on CircleCI!
Details
ci/circleci: py36x Your tests passed on CircleCI!
Details
ci/circleci: py37x Your tests passed on CircleCI!
Details
codecov/patch/typehint 45.12% of diff hit (target 44.94%)
Details
codecov/patch/unittest 100% of diff hit (target 96.29%)
Details
codecov/project/typehint Absolute coverage decreased by -0.29% but relative coverage increased by +0.17% compared to 5b13a15
Details
codecov/project/unittest 96.29% (+<.01%) compared to 5b13a15
Details
@daltonmatos daltonmatos deleted the feature/http-client branch Aug 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.