Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/document http client #171

Merged

Conversation

@daltonmatos
Copy link
Member

daltonmatos commented Aug 19, 2019

No description provided.

daltonmatos added 3 commits Aug 19, 2019
@codecov

This comment has been minimized.

Copy link

codecov bot commented Aug 19, 2019

Codecov Report

Merging #171 into feature/remove-legacy-http-client will not change coverage.
The diff coverage is 100%.

Flag Coverage Δ
#typehint 45.85% <ø> (ø) ⬆️
#unittest 96.23% <100%> (ø) ⬆️
Impacted Files Coverage Δ
asgard/http/client.py 91.07% <100%> (ø) ⬆️
@daltonmatos daltonmatos merged commit ae8d28d into feature/remove-legacy-http-client Aug 19, 2019
7 checks passed
7 checks passed
ci/circleci: py368 Your tests passed on CircleCI!
Details
ci/circleci: py36x Your tests passed on CircleCI!
Details
ci/circleci: py37x Your tests passed on CircleCI!
Details
codecov/patch/typehint Coverage not affected when comparing 940ed82...ae8d28d
Details
codecov/patch/unittest 100% of diff hit (target 96.23%)
Details
codecov/project/typehint 45.85% remains the same compared to 940ed82
Details
codecov/project/unittest 96.23% (+0%) compared to 940ed82
Details
@daltonmatos daltonmatos deleted the feature/document-http-client branch Aug 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant
You can’t perform that action at this time.