Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/migrate mesos backend to new model converter #178

Merged

Conversation

@daltonmatos
Copy link
Member

daltonmatos commented Aug 29, 2019

Migração da lógica que busca a lista de Agents no mesos para usar o novo modelo de conversão baseado no ModelConverterInterface[A, B].

@daltonmatos daltonmatos force-pushed the feature/migrate-mesos-backend-to-new-model-converter branch from 2b76cf5 to 021a480 Aug 29, 2019
daltonmatos added 8 commits Aug 21, 2019
A implementação do `to_client_model()` ficou para depois pois
os endpoins que listam os agents do mesos são apenas leitura então
não enviaremos nada para a API do Mesos.

Se surgir a necessidade de fazer o `to_client_model()` faremos no futuro.
Agora usamos MesosAgentConverter.to_asgard_model() em vez de usar
`client_model.to_asgard_model()`
@daltonmatos daltonmatos force-pushed the feature/migrate-mesos-backend-to-new-model-converter branch from 021a480 to 810e0d1 Aug 29, 2019
@codecov

This comment has been minimized.

Copy link

codecov bot commented Aug 29, 2019

Codecov Report

Merging #178 into master will increase coverage by 0.14%.
The diff coverage is 100%.

Flag Coverage Δ
#typehint 46.23% <96.49%> (+1.74%) ⬆️
#unittest 97.34% <100%> (+0.04%) ⬆️
Impacted Files Coverage Δ
asgard/models/spec/attributes.py 100% <100%> (ø)
asgard/models/spec/resources.py 100% <100%> (ø)
asgard/backends/mesos/models/converters.py 100% <100%> (ø)
asgard/clients/mesos/client.py 96.77% <100%> (ø)
asgard/backends/mesos/impl.py 100% <100%> (ø) ⬆️
asgard/clients/mesos/models/spec.py 100% <100%> (ø)
asgard/clients/mesos/models/agent.py 100% <100%> (ø)
... and 2 more
@pabrrs
pabrrs approved these changes Aug 30, 2019
@daltonmatos daltonmatos merged commit 810e0d1 into master Sep 2, 2019
7 checks passed
7 checks passed
ci/circleci: py368 Your tests passed on CircleCI!
Details
ci/circleci: py36x Your tests passed on CircleCI!
Details
ci/circleci: py37x Your tests passed on CircleCI!
Details
codecov/patch/typehint 96.49% of diff hit (target 44.49%)
Details
codecov/patch/unittest 100% of diff hit (target 97.3%)
Details
codecov/project/typehint 46.23% (+1.74%) compared to 1b19f6a
Details
codecov/project/unittest 97.34% (+0.04%) compared to 1b19f6a
Details
@daltonmatos daltonmatos deleted the feature/migrate-mesos-backend-to-new-model-converter branch Sep 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.