Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tornando o `used_resources.ports` opcional #180

Merged
merged 2 commits into from Oct 4, 2019

Conversation

@daltonmatos
Copy link
Member

daltonmatos commented Oct 4, 2019

Em uma task com net=host o uso de portas não é contabilizado
pois essa task não consome nenhuma porta ofertada pelo mesos.

Então em um slave rodando apenas tasks com net=host o JSON que volta da
API do mesos não tem o campo used_resources.ports.

Em uma task com net=host o uso de portas não é contabilizado
pois essa task não consome nenhuma porta ofertada pelo mesos.

Então em um slave rodando apenas tasks com net=host o JSON que volta da
API do mesos não tem o campo `used_resources.ports`.
@codecov

This comment has been minimized.

Copy link

codecov bot commented Oct 4, 2019

Codecov Report

Merging #180 into master will not change coverage.
The diff coverage is 100%.

Flag Coverage Δ
#typehint 46.23% <100%> (ø) ⬆️
#unittest 97.34% <100%> (ø) ⬆️
Impacted Files Coverage Δ
asgard/clients/mesos/models/spec.py 100% <100%> (ø) ⬆️
@daltonmatos daltonmatos merged commit cc977b8 into master Oct 4, 2019
7 checks passed
7 checks passed
ci/circleci: py368 Your tests passed on CircleCI!
Details
ci/circleci: py36x Your tests passed on CircleCI!
Details
ci/circleci: py37x Your tests passed on CircleCI!
Details
codecov/patch/typehint 100% of diff hit (target 46.23%)
Details
codecov/patch/unittest 100% of diff hit (target 97.34%)
Details
codecov/project/typehint 46.23% (+0%) compared to e4a359a
Details
codecov/project/unittest 97.34% (+0%) compared to e4a359a
Details
@daltonmatos daltonmatos deleted the fix/used-resources-port-as-optional branch Oct 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant
You can’t perform that action at this time.