Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consertada decisões quando app já está utilizando recurso ao máx/min #196

Merged
merged 7 commits into from Jan 23, 2020

Conversation

@rockerbacon
Copy link
Collaborator

rockerbacon commented Jan 16, 2020

Conforme verificado ao investigar a issue #195, o componente de decisão estava enviando decisões ao Asgard mesmo quando a decisão não alterava a configuração da APP.

O problema estava ocorrendo pois, em casos onde a aplicação já estava utilizando os recursos ao mínimo/máximo, o decisor decidia escalar a aplicação mas sua decisão era limitada pelos valores mínimos/máximos, que já estavam uso.

@rockerbacon rockerbacon requested a review from daltonmatos as a code owner Jan 16, 2020
@codecov

This comment has been minimized.

Copy link

codecov bot commented Jan 16, 2020

Codecov Report

Merging #196 into master will increase coverage by 0.17%.
The diff coverage is 68%.

Flag Coverage Δ
#typehint 46.9% <16.21%> (-0.11%) ⬇️
#unittest 97.35% <100%> (ø) ⬆️
Impacted Files Coverage Δ
asgard/workers/converters/asgard_converter.py 100% <100%> (ø) ⬆️
asgard/workers/models/app_stats.py 100% <100%> (ø) ⬆️
asgard/workers/models/scalable_app.py 100% <100%> (ø) ⬆️
...rd/workers/autoscaler/simple_decision_component.py 66.66% <56.75%> (+4.64%) ⬆️
rockerbacon added 2 commits Jan 16, 2020
@daltonmatos

This comment has been minimized.

Copy link
Member

daltonmatos commented Jan 22, 2020

@rockerbacon, o que falta aqui para podermos fazer o merge? Tem mais algo que queira implementar?

@rockerbacon

This comment has been minimized.

Copy link
Collaborator Author

rockerbacon commented Jan 22, 2020

@rockerbacon, o que falta aqui para podermos fazer o merge? Tem mais algo que queira implementar?

Já está tudo pronto, pode fazer o merge

@daltonmatos daltonmatos merged commit 44063db into b2wdigital:master Jan 23, 2020
5 of 7 checks passed
5 of 7 checks passed
codecov/patch/typehint 16.21% of diff hit (target 47%)
Details
codecov/project/typehint 46.9% (-0.11%) compared to 1c1eb19
Details
ci/circleci: py368 Your tests passed on CircleCI!
Details
ci/circleci: py36x Your tests passed on CircleCI!
Details
ci/circleci: py37x Your tests passed on CircleCI!
Details
codecov/patch/unittest 100% of diff hit (target 97.34%)
Details
codecov/project/unittest 97.35% (+<.01%) compared to 1c1eb19
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.