Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/modernize api tests #206

Merged
merged 12 commits into from Mar 5, 2020
Merged

Feature/modernize api tests #206

merged 12 commits into from Mar 5, 2020

Conversation

@daltonmatos
Copy link
Member

daltonmatos commented Mar 1, 2020

Tarefas

  • Instalar werkzeug==0.16. O Flaskoauthlib se diz compatível com >= 0.14 mas não parece ser verdade.
  • Atualizar pydantic pra 0.32.2. Precisa atualizar no asyncworker. Aqui talvez tenhamos que gerar uma nova versão (0.12.0) com o pydantic atualizado.

Esse PR faz basicamente todos os testes não dependerem mais de uma porta específica para fazer testes de API, ou seja, testes que precisam dar boot na App asyncworker para fazer requests HTTP.

daltonmatos added 7 commits Feb 29, 2020
Nessa versão a msg de validação é diferente e inclui o nome do modelo
@daltonmatos daltonmatos force-pushed the feature/modernize-api-tests branch 2 times, most recently from e0ebb7e to 1f05030 Mar 1, 2020
daltonmatos added 3 commits Mar 1, 2020
@daltonmatos daltonmatos force-pushed the feature/modernize-api-tests branch from 1868f57 to a09a3e3 Mar 4, 2020
daltonmatos added 2 commits Mar 4, 2020
Apesar do Flask-OAuthlib se dizer compatível com werkzeug >= 0.14

```
Flask-OAuthlib==0.9.5
  - Flask [required: Any, installed: 1.0.2]
    - click [required: >=5.1, installed: 7.0]
    - itsdangerous [required: >=0.24, installed: 1.1.0]
    - Jinja2 [required: >=2.10, installed: 2.11.1]
      - MarkupSafe [required: >=0.23, installed: 1.1.1]
    - Werkzeug [required: >=0.14, installed: 1.0.0]

```

Isso não é verdade. Quando usandom `werkzeug==1.0.0` vemos essas
exceptions durante a rodada de testes:

```
   from flask_oauthlib.client import OAuth
../../../.local/share/virtualenvs/asgard-api-JX-ZQxSl/lib/python3.6/site-packages/flask_oauthlib/client.py:18: in <module>
    from werkzeug import url_quote, url_decode, url_encode
E   ImportError: cannot import name 'url_quote'
```
@daltonmatos daltonmatos merged commit ef17e68 into master Mar 5, 2020
5 checks passed
5 checks passed
ci/circleci: py368 Your tests passed on CircleCI!
Details
ci/circleci: py36x Your tests passed on CircleCI!
Details
ci/circleci: py37x Your tests passed on CircleCI!
Details
codeclimate/diff-coverage 100% (50% threshold)
Details
codeclimate/total-coverage 97% (0.0% change)
Details
@daltonmatos daltonmatos deleted the feature/modernize-api-tests branch Mar 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant
You can’t perform that action at this time.